Adapt MNIST example to use the original lecun data files - #97
Conversation
|
The CI seems to confirm that it's not just an issue with my setup. |
|
The Let me do that in a separate PR. |
erikd
left a comment
There was a problem hiding this comment.
In general PRs should change only what absolutely must be changed.
| 'D3 12 12 18, 'D3 4 4 18, 'D3 4 4 18, | ||
| 'D1 288, 'D1 80, 'D1 10 ] | ||
| type MNIST | ||
| = Network |
There was a problem hiding this comment.
More semantically NULL changes.
|
I am actually wondering why we don't just update the documentation. |
|
For PR branches like this one, you really should rebase rather than merge, |
| @@ -0,0 +1,26 @@ | |||
| stack=cabal | |||
There was a problem hiding this comment.
Is that a comma in that file name or a period?
Should probably also use a #!/bin/bash -eu at the top as well.
There was a problem hiding this comment.
Also, can stack and cabal be use interchangablly there?
There was a problem hiding this comment.
I think this shell script can be made quite a bit nicer. I can do that but may not get a chance before the weekend.
There was a problem hiding this comment.
Sounds good. The script is an extract of a retread of a retread :-)
|
The CI fails because gan-mnist takes too long to generate 15 examples. mnist itself still uses too much memory to run. |
|
Where is this this PR going? If this is ever to be merged it should be rebased against master and commits like "ci typo" need to be squashed down. |
|
Thanks @erikd. I want to find time over the w/e to kick the tyres some more:
Are you going to be able to refactor the script? |
|
Probably best if I wait until you finish what you are working on and then assuming everything is ok, I will do done final clean up run |
erikd
left a comment
There was a problem hiding this comment.
Big PRs with mainy unrelate changes are far more difficult to review than a series of small PRs that only change one thing.
There is already one large, long running PR against Grenade that is likely to never be merged because it contains a huge number of unrelated changes and that PR branch has diverged from master. Changes on that branch will be need to be cherry picked, tested, evaluated indvcidiually which is significantly more work that if they had been submitted as s stream of small simple PRs.
| , split | ||
| , zlib | ||
|
|
||
| executable iris |
There was a problem hiding this comment.
A new example is a great idea, but should probably be a separate PR from the other changes you are making.
Having them a separate make reviewing both PRs easier.
There was a problem hiding this comment.
Understood. In this case the changes are focused on making the examples run (which they now do, as you can see from the travis output). I think that I've got to a stage where the pieces are in place. If you want to improve the run scripts, I think that that would be good. I'd be happy to flesh out some of the documentation, if that would help.
There was a problem hiding this comment.
Not too sure it the examples should run in CI. Will have a look.
This version downloads and uses the MNIST data files, converting the data from Word8 to Double. The
runMNIST.shscript does the work.Unfortunately, it still runs out of memory on my Ubuntu VM...
Anyway, I hope that it's of some use.