Repository navigation
DigiYatra case study: skeleton placeholder for legacy phone shots - #16
Merged
Merged
Conversation
The legacy 'before' screenshots are lazy-loaded; before a shot painted (or on any slow/flaky connection or load failure) the bezel flashed its raw grey alt text and the browser broken-image glyph on a white screen, which read as a broken phone. Give the bezel screen a neutral skeleton, hide the alt text visually with color:transparent (the attribute stays for screen readers), and hide the <img> on error so a hard failure shows only the skeleton.
Deploying ux4g with
|
| Latest commit: |
c56b67d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2dbd2788.ux4g.pages.dev |
| Branch Preview URL: | https://digiyatra-legacy-skeleton.ux4g.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The legacy "before" screenshots in the DigiYatra case study are lazy-loaded. Before a shot painted — or on any slow/flaky connection, cache miss, or load failure — the phone bezel flashed its raw grey
alttext ("The old DigiYatra login screen") plus the browser's broken-image glyph on a white screen. It looked like a broken phone. (This is the faint "bra" fragment a quick scroll catches.)Fix (
OldPhoneonly)color: transparenton the<img>hides the alt text visually — the attribute stays in the DOM, so screen readers still announce it.onErrorhides the<img>outright, so a genuine load failure shows only the skeleton (no glyph).The live "after" phones (real prototype component) are untouched.
Verified (Playwright, 390px @2x)
altattributes remain in the DOM (a11y intact).astro check: 0 errors / 0 warnings / 0 hints. Production build green.