Repository navigation
docs: consolidate Phase B.2 documentation and consistency checks - #49
Merged
Merged
Conversation
- Introduced T-073 for console_write copy-path performance decision, outlining user story, context, acceptance criteria, and approach. - Added T-074 for running the Phase C readiness sweep, consolidating SMP-readiness items into a single index. - Created T-075 to close Phase B.2, ensuring all findings are accounted for and the roadmap is updated. - Established ADR-0040 to govern the Phase B.2 consolidation bridge, detailing decision drivers, options considered, and consequences.
- T-048: Added `docs/roadmap/current.md` to the `git diff --stat` check. - T-049: Updated `git diff --stat` to include `docs/roadmap/current.md`. - T-050: Included `docs/roadmap/current.md` in the `git diff --stat` check. - T-051: Added `docs/roadmap/current.md` to the `git diff --stat` requirement. - T-052: Updated `git diff --stat` to include `docs/roadmap/current.md`. - T-053: Included `docs/roadmap/current.md` in the `git diff --stat` check. - T-054: Added `docs/roadmap/current.md` to the `git diff --stat` requirement. - T-055: Updated `git diff --stat` to include `docs/roadmap/current.md`. - T-056: Modified the shellcheck requirement for cross-platform compatibility. - T-063: Enhanced compile-time guard for syscall error taxonomy. - T-071: Clarified ADR-0009 revision-note rider requirements. - T-074: Updated task dependencies for pulled-forward items. - T-075: Expanded task dependencies to include future tasks in Phase B.2.
Review existing CI, source and governance before implementation. Propose concrete cadence, ARM verification and merge-policy choices in ADR-0040; retain Proposed status for maintainer approval. Refs: ADR-0040 Code-Review: docs/analysis/reviews/code-reviews/2026-10-11-phase-b2-track1-preflight.md
Correct the source-inaccurate release smoke deferral and the remaining exit-accounting claim found by independent preflight review. Align task dependencies with the chosen protection policy and record schedule limitations and release boot evidence. Refs: ADR-0040
Qualify baseline soundness claims and require a matching debug userland image before perf-bench compilation. Record both fresh second-round approvals and the independently inspected debug and release boot baselines. Refs: ADR-0040
Resolve the supplied approval-review findings M1 and L1-L4. Preserve historical supersession records, clarify pre-Acceptance status labels, and justify the existing direct Phase D gate without changing its scope. Refs: ADR-0040
Reconcile the current ADR ledgers, preserve the Proposed lifecycle history, and correct coverage region/line labels. Record the independent approval audit and reproduced baseline failures without claiming implementation or task completion. Refs: ADR-0040
Record the maintainer approval after resolving the supplied review findings, independently verifying the revised proposal, and rereading the full ADR. Synchronize live pointers and settle T-035/T-036 design choices as Ready without claiming implementation or Done promotion. Refs: ADR-0040
ARM hosts matched the architecture-only gates and selected the Tyrne entry, panic handler and linker script. Require target OS none consistently so workspace tooling uses host stubs. Keep the existing SVC assembly and bare-metal image bytes unchanged; append the compilation-boundary audit amendment. Native ARM workspace checks and Miri now pass, with 366 tests and unchanged debug image SHA-256. Refs: ADR-0040 Audit: UNSAFE-2026-0033
Correct the two verified lifecycle findings from the first independent code review and synchronize the live task, review and development-branch pointers. Preserve the opening snapshot and historical roadmap records. Record the separate security checklist and audit approval specifically for target selection; the unchanged x2 defect remains owned by T-038. The second fresh code/security round remains pending. Refs: ADR-0040 Audit: UNSAFE-2026-0033 Security-Review: b21_step1_round1_security
Record fresh code and security approvals of the implementation and first-round corrections. No new finding requires a source fix. Preserve both reviewers' exact verification scopes and the T-038 exclusion. T-037 stays In Review; its implementation gates and two fresh rounds now permit the next step under the Accepted stacked-execution policy. Refs: ADR-0040 Audit: UNSAFE-2026-0033 Security-Review: b21_step1_round2_security
Add tested flag/environment precedence and usage errors to both runners. Refresh the QEMU guide and run the stub argument checks in the fast CI lane. Refs: ADR-0040
Refs: ADR-0040
Record independent Bash 3, regression-sensitivity, profile and Perl-fallback evidence alongside the green hosted run. Both reviewers approve; no source fix was required. Refs: ADR-0040
Record both fresh second-round reports and resolve Low R2-INT-01: task A spins after completion. Correct the guide and matching smoke/performance descriptions; preserve historical review prose with an explicit reconciliation. Refs: ADR-0040 Code-Review: docs/analysis/reviews/code-reviews/2026-10-12-t033-qemu-tooling.md
Enforce bare-metal userland clippy and ShellCheck in existing required jobs. Correct measured quoting findings and prove each lint command rejects a deliberate regression in an isolated worktree copy. Refs: ADR-0040
Apply the Accepted ADR-0040 policy, document exact commands and negative probes, and record T-031 local verification. Hosted results and both fresh review rounds remain pending. Refs: ADR-0040
ShellCheck 0.9.0 reports the indirect cleanup callback as SC2317 rather than 0.11.0's SC2329. Scope both measured false-positive suppressions to that function with its trap reason. Refs: ADR-0040
Record the independent first review round and separate local and hosted lint evidence. Synchronize downstream gate summaries with the accepted target-aware policy. Refs: ADR-0040 Code-Review: docs/analysis/reviews/code-reviews/2026-10-12-t031-lint-gates.md
Record both fresh independent second-round reports and correct their verified Low current-focus status finding. Preserve the failed first hosted run and distinguish development evidence from final maintainer approval. Refs: ADR-0040 Code-Review: docs/analysis/reviews/code-reviews/2026-10-12-t031-lint-gates.md
Build and lint matching release images, test release host crates, and require both named console gate tests to execute. Prove the profile-flip regression is rejected in an isolated copy and restore the debug image before perf-bench build and lint. Scope debug-only test imports without changing syscall behavior. Refs: ADR-0040 Refs: ADR-0031 Refs: ADR-0039
Reconcile required-gate summaries and release process with the already Accepted ADR-0040. Keep release runtime smoke explicitly pending its owning T-034 step. Refs: ADR-0040
Record first green release/perf CI, exact release test totals and step wall time, named-test assertion, isolated hosted profile-flip rejection and matching image order. Keep both independent review rounds pending. Refs: ADR-0040
Publish full independent code and security approvals, retaining evidence provenance and the existing T-038 exclusion. No source findings require correction; a report precision correction distinguishes additional passing tests from ignored tests. Keep the second fresh round and final maintainer review pending. Refs: ADR-0040, ADR-0031, ADR-0039 Code-Review: docs/analysis/reviews/code-reviews/2026-10-12-t030-release-gates.md Security-Review: b21_step4_round1_security (docs/analysis/reviews/security-reviews/2026-10-12-t030-release-gates.md)
Record full fresh code and security approvals with independent real and controlled release-gate verification. No new finding requires a source fix. Keep final maintainer PR review pending and preserve the existing T-038 exclusion. Refs: ADR-0040, ADR-0031, ADR-0039 Code-Review: docs/analysis/reviews/code-reviews/2026-10-12-t030-release-gates.md Security-Review: b21_step4_round2_security (docs/analysis/reviews/security-reviews/2026-10-12-t030-release-gates.md)
Deny panic, unwrap and expect in the HAL and BSP, retaining ten function-scoped reasoned exceptions for trusted boot/demo/benchmark invariants and deliberate fatal aborts. Exercise both exact clippy aliases with isolated None-unwrap regressions locally and in CI. Unmap reuses the existing typed root for an ignored physical-frame argument instead of constructing and unwrapping a dummy frame. Literal unmap=true leaves descriptor access, ownership, lifetime and TLB obligations unchanged. A lint allowance on this non-init MMU path adds no benefit; preserve the original audit and append the changed reasoning for distinct security review. Refs: ADR-0040 Audit: UNSAFE-2026-0025
Record the actual implementation SHA in the appended unsafe amendment and keep hosted rejection evidence and distinct security approval pending until observed. Refs: ADR-0040 Audit: UNSAFE-2026-0025
Discover all stored workspace sources with guarded bounded Cargo parsing. Separate real references, active annotations and historical Removed mentions. Refs: ADR-0040, ADR-0043, T-056
Join selected tasks and active pointers to metadata, and reconcile phase census with portable bounded counts while keeping history outside live scope. Refs: ADR-0040, ADR-0043, T-056
Run all eight families by default with explicit subsets and isolated CLI controls. Wire both fixture suites and the corpus into the existing lint job, preserving required contexts and documenting bounded grammar and limits. Refs: ADR-0040, ADR-0043, T-056
Reconcile all six first-round groups without narrowing the approved corpus. Preserve original live block context, visible review discovery and source scope; index redirection literals and include root Cargo local overrides. Retain failing-before streams, intermediate author corrections and source-bound 161 navigation/111 metadata tests on Python 3.9 and 3.13. Both final corpus runs pass with stable inputs. Record explicit combined-publication authorization. R1 committed-fix verification, fresh R2 and hosted evidence remain pending. Refs: ADR-0043
cemililik
changed the title
Handle raw attribute identifiers without confusing cfg predicates with paths. Preserve HTML block termination and blank-line context, including CDATA, processing instructions, declarations and cross-name raw-tag closing lines. Avoid copying distant suffixes when rejecting unsupported source redirections. Retain both tests-first increments and 161 navigation/115 metadata passes on Python 3.9 and 3.13. Final corpus inputs are stable with zero findings. Preserve the earlier successful hosted checkpoint separately from these newer repairs. Same-reviewer R1 verification and different fresh R2 remain pending. Refs: ADR-0040, ADR-0043
Separate strict type 7 block recognition from browser-style HTML navigation and type 6 structural prefixes. Malformed attributes must not suppress real Markdown destinations or standards opening fences. Preserve both tests-first drafts and expanded link/fence/live regressions. 161 navigation and 118 metadata methods pass on Python 3.9 and 3.13; both final corpus commands report zero findings with stable inputs. Keep prior hosted checkpoints bound to their original commits. Same-round review remains pending. Refs: ADR-0040, ADR-0043
Preserve all sixteen original reports and complete recoverable reviewer evidence, including historical HOLDs and the final scoped closure of six reported groups at 770d86b. Record actual source-bound Linux checks and the active different fresh second round without promoting T-056. Refs: ADR-0013, ADR-0040, ADR-0043
Exclude fenced, raw and inline HTML attribute text from task/ADR headers, live fields and companion ownership while retaining original offsets, leading-header boundaries and navigation. Keep tests-first failures, harness QA and independent R2 reports with the six new regressions. Refs: ADR-0040, ADR-0043
Record both fresh paired rounds, verified correction closures and exact-source hosted proof. Retain original reports and lossless evidence; move T-056 to In Review and start integrated Step 13. Code-Review: docs/analysis/reviews/code-reviews/2026-10-15-t056-integration.md Security-Review: docs/analysis/reviews/security-reviews/2026-10-15-t056-integration.md Refs: ADR-0013, ADR-0040, ADR-0043, T-056
Map all 58 opening findings and all 156 task criteria to current implementation and owning reviews. Verify nine architecture source markers, preserve original hosted traces and reconcile six entry documents with twelve tasks In Review and 26 unimplemented tasks. Refs: ADR-0013, ADR-0040, ADR-0042, ADR-0043, T-045, T-046, T-047, T-048, T-049, T-050, T-051, T-052, T-053, T-054, T-055, T-056
Fix SECURITY-R1-01 by directing both README evidence rows to the repository root. Independently compare all 58 displayed destinations with the disposition ledger; retain the two original mismatches and zero-mismatch corrected checks. Refs: ADR-0040, ADR-0043, T-050
Record both fresh integrated code and security rounds, the verified README-target correction and complete original evidence. Reconcile all six entry documents and the approved plan with implementation complete, twelve tasks In Review and maintainer wording/merge gates retained. Code-Review: docs/analysis/reviews/code-reviews/2026-10-15-phase-b2-track2-integration.md Security-Review: docs/analysis/reviews/security-reviews/2026-10-15-phase-b2-track2-integration.md Refs: ADR-0013, ADR-0040, ADR-0042, ADR-0043, T-045, T-046, T-047, T-048, T-049, T-050, T-051, T-052, T-053, T-054, T-055, T-056
Record the approved archive and bounded history migration plan, verified recovery baseline and existing-task maintenance criteria. Acceptance follows a deliberate reread and fresh independent reviews. Refs: ADR-0044, ADR-0043, ADR-0025
Preserve table continuity so the ADR metadata join includes the new Proposed record. Refs: ADR-0044
Resolve GR1-C01 and INT-R1-01 with an explicit archival release profile and grounded post-Acceptance standard reconciliation. Preserve product release gates and signing requirements. Refs: ADR-0044, ADR-0043
Preserve both fresh complementary rounds and committed-fix verification without overwriting initial verdicts. Close the sole Medium clarification; archival execution remains pending. Refs: ADR-0044, ADR-0043, ADR-0025
Accept the maintainer-approved policy after deliberate reread, both fresh complementary rounds and verified closure of the release-scope clarification. Implementation follows this decision boundary. Refs: ADR-0044, ADR-0043, ADR-0025
Apply the Accepted evidence-only release scope pointer before publication and reopen T-049/T-056 with synchronized live-state inventory. Preserve the initial ADR filing as history with an append-only Acceptance record. Refs: ADR-0044, ADR-0043, ADR-0025
Retain all payloads and old source in a verified immutable release, preserve exact historical identities and migrate 348 links with 46 byte-exact reversal checks. Record public recovery, bounded local rewrite and the reproducible generator correction; remote development remains untouched. Refs: ADR-0044, ADR-0043, ADR-0025
Resolve MRC1-01 by distinguishing verified immutable archival and local migration from pending reviews, prevention, lease publication and hosted gates. Preserve the original migration proof at its actual source. Refs: ADR-0044, ADR-0043
Preserve both fresh complementary rounds and the verified Low live-pointer correction. Return T-049 to In Review while T-056 prevention, exact remote lease and final hosted validation remain active. Refs: ADR-0044, ADR-0043, ADR-0025
Pin index and complete-history verification with offline fail-closed inputs and meaningful temporary Git fixtures. Clarify release-pointer timing against the already-approved step-six guidance order. Refs: ADR-0044, ADR-0043
Check the index and complete HEAD history with offline Git fixtures, reject hidden or incomplete ancestry, and document the accepted retention contract in the existing required lint job. Refs: ADR-0043, ADR-0044
Convert Python 3.9 symlink-loop resolution failures into the documented input error. A real CLI regression fails before the repair and passes with all22 fixtures on both supported runtimes. Refs: ADR-0044
Ignore derived commit-graph metadata so an inconsistent cache cannot hide oversized historical artifacts. A real cache regression fails on both supported runtimes before the repair; all23 footprint methods now pass. Refs: ADR-0044
Preserve all eight complete source-bound reports and verified digests. Both fresh complementary rounds close the Low input error and Medium cache-ancestry groups with actual committed-fix verification; final hosted publication remains gated. Refs: ADR-0013, ADR-0043, ADR-0044 Code-Review: docs/analysis/reviews/code-reviews/2026-10-16-pr49-evidence-prevention.md
cemililik
force-pushed
the
development
branch
from
October 15, 2026 22:51
97dbcd1 to
daeda78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivered change
Phase B had closed while architecture chapters, task/review indexes, standards and entry documents still described older behavior. This combined PR records B.2-1 post-merge bookkeeping and implements all twelve B.2-2 documentation/tooling tasks under the approved plan.
Review footprint and retained evidence
Final merged diff: 217 files, +31,969/-3,003, versus original 1,008 files, +956,905/-3,003. The retained diff contains actual documentation, checker/fixture implementation and complete canonical reviews. All 804 migrated files (134,293,614 current-tree bytes) and the old source remain recoverable. The explicitly approved narrow development rewrite used one exact original97 lease; meaningful ordering and the original-to-new map remain. Main/protection/unrelated refs were not rewritten by the agent. The approved evidence tag points to clean historical main; release immutability was enabled as approved.
Immutable archive · Catalog · Recovery guide
Every implementation step and all three retention units completed two different fresh complementary rounds with verified corrections. Canonical reports preserve original differing verdicts, severities, exact sources and actual reading/execution limits. Zero unresolved verified scoped findings; no historical execution was relabeled as running on a rewritten SHA. No executable Rust or dependency change; the two HAL updates are documentation comments.
Actual validation and merge
Reviewed/published development source:
daeda787b3a5ec5221085a1daf4eca5aecbd1857.The maintainer merged at
52fa323d20d92531add563561376a22ae607a537, 2026-10-15 22:55:20 UTC / 2026-10-16 01:55:20 Europe/Istanbul. Its tree equals the reviewed source exactly. First-main CI38820329507 passes all seven jobs/six app-15368 contexts; full protection read-back is unchanged. Actual clean-main debug/release smoke traces and 23 rejection controls were downloaded and inspected.Completion bookkeeping and next work
After merge, the maintainer explicitly authorized Done. Post-merge documentation PR50 on the same development branch records T-045–T-056 Done/date_done 2026-10-16, 161/161 checked criteria (156 original plus five maintenance), completed human SECURITY approval authority, synchronized indexes/current state and the source-bound completion retrospective. That small followup changes documentation only and keeps the actual UTC merge timestamp distinct from the local completion date.
B.2 inventory after completion: 20 Done/19 Ready/7 Draft; 26 tasks remain. HIGH T-038 is the next Ready candidate and is unstarted. B.2 remains Active and continues to gate C/D; this PR closes neither the full phase nor later correctness/quality work.