Skip to content

docs: fix KTO data-shape row to use completion column #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cemililik merged 4 commits into from
Oct 17, 2026
Merged

docs: fix KTO data-shape row to use completion column #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c804e3c
docs: fix KTO data-shape row to use completion column
vortsghost2025 Oct 14, 2026
c1c0381
Merge branch 'development' into fix/kto-docs-completion-885
cemililik Oct 17, 2026
e934508
docs(changelog): record the KTO data-shape fix
cemililik Oct 17, 2026
10b2ce2
Merge branch 'development' into fix/kto-docs-completion-885
cemililik Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ All notable changes to ForgeLM are documented here.
article and gender slips in the touched German, French and Spanish strings, and use one German term
for the external stack. The new validation and interval keys keep their English fallback; native
review of the deferred locales remains open (refs #948).
- Name the right columns for KTO in the EN/TR "Choosing a Trainer" user manual: its data-shape table
said `{prompt, response, label: bool}`, but the loader requires `{prompt, completion, label}` and
rejects the old shape with a `KeyError` (F-W1-DOCS-TRAIN-02, #885). The table's SFT row is a separate
defect, tracked in #403, and is unchanged here.
- Say what Annex IV §9 asks for: a detailed description of the post-market monitoring system, its
plan included. The wizard hint in every locale and the EN/TR configuration and compliance pages said
it "includes the detailed plan"; German, French and Spanish now follow the Regulation's wording, and
Expand Down
2 changes: 1 addition & 1 deletion docs/usermanuals/en/concepts/choosing-trainer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ flowchart TD
|---|---|
| `{prompt, completion}` rows only | [SFT](#/training/sft) |
| `{prompt, chosen, rejected}` rows | [DPO](#/training/dpo) (or [SimPO](#/training/simpo) if VRAM-tight) |
| `{prompt, response, label: bool}` rows | [KTO](#/training/kto) |
| `{prompt, completion, label: bool}` rows | [KTO](#/training/kto) |
| Mix of SFT and preference rows | [SFT](#/training/sft) → [DPO](#/training/dpo) sequence, or [ORPO](#/training/orpo) for one-stage |
| Programmatic reward (math grader, code tests) | [GRPO](#/training/grpo) |

Expand Down
2 changes: 1 addition & 1 deletion docs/usermanuals/tr/concepts/choosing-trainer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ flowchart TD
|---|---|
| Sadece `{prompt, completion}` satırları | [SFT](#/training/sft) |
| `{prompt, chosen, rejected}` satırları | [DPO](#/training/dpo) (VRAM dar ise [SimPO](#/training/simpo)) |
| `{prompt, response, label: bool}` satırları | [KTO](#/training/kto) |
| `{prompt, completion, label: bool}` satırları | [KTO](#/training/kto) |
| SFT ve tercih satırlarının karışımı | [SFT](#/training/sft) → [DPO](#/training/dpo) sıralı, veya tek aşama için [ORPO](#/training/orpo) |
| Programatik reward (math grader, kod testi) | [GRPO](#/training/grpo) |

Expand Down
Loading