Skip to content

Internal mypy debt has grown past its recorded budget: 108 errors in 36 files against 106 in 35 #917

Open

Description

@cemililik

Deferred work · F-W20260729-OPS-23-internal · severity Low · cost ~1-2 days · recorded in docs/roadmap/risks-and-decisions.md:262

Summary

Phase 16 S1 wired the public-surface mypy --strict gate and recorded the package-wide typing debt as a budget instead of a blocker: 106 errors across 35 files, measured with mypy 1.20.2 and ./.venv/bin/python -m mypy --ignore-missing-imports forgelm/, with growth past 106 named as the signal to act. That signal has fired, and nothing in CI enforces the budget, which is why the growth went unnoticed.

Condition or budget

"Growth past 106 is the signal to act" — met: the recorded command reports 108 errors in 36 files on 2026-10-09.

State today (re-checked 2026-10-09)

Re-measured on development with the recorded command and mypy 1.20.2: Found 108 errors in 36 files (checked 104 source files).

Related

#748 corrects the stale "47" in the Phase 16 plan (documentation only).

Acceptance criteria

  • The count is back to 106 or below, or the budget is re-baselined with a written reason.
  • Growth past the budget fails CI (a ratchet), so the next increase is caught when it happens.
  • The row is removed from the deferral table and the CHANGELOG names its ID (the table's removal contract).

Recorded in docs/roadmap/risks-and-decisions.md (read at f94595f) and re-checked against the code on 2026-10-09. The row leaves that table only when the fix is on main, the CHANGELOG names its ID and any promised guard exists.

Activity

  1. added
    severity: lowMinor defect, inaccuracy or rough edge
    wave: 4Roadmap wave 4: low / info / watch, when touching the module
    source: roadmapPlanned or deferred work recorded in docs/roadmap/
    on Oct 9, 2026
  2. cemililik commented on Oct 20, 2026

    @cemililik
    CollaboratorAuthor

    Re-measured on 2026-10-21 with the recorded command (python -m mypy --ignore-missing-imports forgelm/, mypy 1.20.2) and a cold cache (--no-incremental): development reports 109 errors in 35 files. A warm incremental cache reported 108 for the same tree, so the budget command should say which of the two it means; a ratchet has to pin it.

    #1046 clears the three errors that forgelm/judge.py contributed (an Any declaration, a re-bound variable, one cast), with no behaviour change. With it the cold count is 106 errors in 34 files, which meets the first acceptance criterion. The ratchet and the removal of the deferral row are still open.

    Not counted by the recorded command and not touched: under --strict judge.py has three more no-any-return findings, two of them in _parse_judge_json, which #1038 rewrites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: dev-toolingCode area: dev-toolingseverity: lowMinor defect, inaccuracy or rough edgesource: roadmapPlanned or deferred work recorded in docs/roadmap/wave: 4Roadmap wave 4: low / info / watch, when touching the module

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions