Repository navigation
[Phase 16] S4 — Dependency-range truth for the six advertised trainers #890
Description
Roadmap · Phase 16, step S4 · size L · 2 unit(s) · planned in
docs/roadmap/phase-16-trust-surface-hardening.md:385-414
Summary
README, the site and the trainer_type enum advertise six alignment methods and both of TRL's data formats; the declared dependency contract delivers neither. ORPOConfig, CPOConfig, ORPOTrainer and CPOTrainer are absent from the top-level trl namespace across the whole declared trl>=1.0.0,<2.0.0 range (checked on the 1.0.0, 1.7.1 and 1.9.2 wheels), so pinning an upper bound cannot fix it. Separately, TRL hands conversational completions to custom rewards as message lists, and all four built-in reward paths assume str.
Units
| Unit | Tracked by (October 2026 review) |
|---|---|
F-W20260729-GAP-03 |
#105 · #106 |
F-W20260729-CORE-02 |
#476 · #708 |
Decisions this step executes
- C-10 — ORPO / SimPO on a dependency range that exports neither: route through
trl.experimental.
Plan
- Add a version-aware
_import_trl_symbolresolver that falls back totrl.experimental.orpo/trl.experimental.cpo, logs one INFO line per fallback naming the instability, and raises an actionable config-error-shaped failure naming the installedtrl.__version__when neither location works. Never setTRL_EXPERIMENTAL_SILENCE(a silent import fallback). - Add
_completion_text()toforgelm/grpo_rewards.pyas the single canonicalisation point, with a documented policy, and route all four reward paths through it. Neverstr(list).
Exit criteria
- All six
trainer_typevalues construct training args and a trainer at both the declared minimum and the resolver-current endpoint with zero skips (asserted withpytest -rs). - A missing advertised trainer class fails; it never
pytest.skip()s. - A parity matrix proves
f(['…']) == f([[{'role':'assistant','content':'…'}]])for all four reward paths, and flat-string outcomes are byte-identical to the baseline. - Two real dependency resolutions (declared minimum and current endpoint) run in CI with the zero-skip assertion enforced.
How to deliver
- One root-cause family, committed on its own; then an Opus review round and a Sonnet review round, each with verified findings fixed and committed before the next step begins.
- A reproducer that is red before the fix and green after; the full gauntlet from
CLAUDE.mdpasses under./.venv/bin/python. - Every English documentation edit ships with its Turkish mirror in the same commit; a new or renamed audit event gets its EN and TR catalog rows in the same PR.
- A step that grows a deferred module carries its
budget_historyjustification in the same diff; a widened guard rolls out non-strict first, then flips. - Commit bodies cite
Absorbs F-W20260729-…; the CHANGELOG[Unreleased]section gets an entry only for a change a user or library consumer can observe (decision C-20).
Planned in docs/roadmap/phase-16-trust-surface-hardening.md (read at f94595f). Unit IDs (F-W20260729-…) come from the 2026-07-29/30 full-project review; the issue numbers next to them are the October 2026 review's records of the same defects.
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsTodo
Activity
fix: resolve ORPO and SimPO classes across TRL export paths
fix: resolve dynamic TRL exports without a dir precondition
fix: pass warmup through the supported Transformers parameter
fix: restore training compatibility and model artifact integrity (#934)
forgelm/trainer.pyinto a sub-package (_kwargs,_runtime,_finalize,_artifacts) — deferred until Phase 16 S4 and S8 have landed #904