Skip to content

Site: the theme-locked --code-comment grey (#6a6f80) on the dark code surface is 3.8:1, below WCAG AA, in both themes (F-W1-SITE-06) #887

Closed

Description

@cemililik

Wave 4 · group W4 Module sweep · highest severity Low · 1 finding(s) · effort small

Summary

Code comments in code blocks and terminal mock-ups, and the small bar titles, language tags and copy buttons on the code surface, use --code-comment: #6a6f80 on --code-bg: #0d1018 — a 3.80:1 contrast ratio, below the 4.5:1 WCAG AA minimum for normal text. The code surface stays dark in light mode as well, so both themes are affected, while site/README.md:105 claims AA on both.

Primary finding

F-W1-SITE-06 — Code-surface comment and label text falls below the AA contrast floor

severity Low (rated Medium by the source review; Low here to match CR-A18-055 in #683, which it should be fixed with) · confidence high · computed from the CSS tokens

What happens. site/css/style.css:56 defines --code-comment; the light theme does not redefine it and keeps --code-bg dark (site/css/style.css:115). The token colours .terminal-body .comment (:1095), .code-block-body .comment (:1390) and the 0.78rem code-surface labels at :1061, :1366, :1401 and :2051. #683 (CR-A18-055) covers the --text-muted pairs, link and button colours and the README claim, but not this token, so fixing --text-muted leaves all of these below 4.5:1.

Where.

Evidence (re-verified on 2026-10-09).

Recommended fix. Raise --code-comment to a grey that reaches at least 4.5:1 on #0d1018 (#7a8090 gives 4.8:1), or give the 0.78rem labels their own token, then re-check every text colour used on the code surface in both themes.

Related. #683 — CR-A18-055, the other contrast tokens and the README AA claim.

Acceptance criteria

  • Every text colour used on the code surface reaches 4.5:1 against --code-bg in both themes.
  • The finding is resolved or explicitly closed with a reason.

Found by the September 2026 independent review of ForgeLM against commit cab2947 and re-verified against development at f94595f on 2026-10-09. Code links point at cab2947; line numbers may have moved since. Finding IDs (F-W1-…) are stable references for this backlog.

Activity

  1. added
    bugSomething isn't working
    severity: lowMinor defect, inaccuracy or rough edge
    wave: 4Roadmap wave 4: low / info / watch, when touching the module
    source: review-2026-09Found by the September 2026 independent review
    on Oct 9, 2026
  2. cemililik commented on Oct 11, 2026

    @cemililik
    CollaboratorAuthor

    Where to start

    Thanks for taking a look. Please confirm the issue is unassigned and comment before starting so work does not overlap.

    Start with these files on development:

    Choose a comment/label gray meeting at least 4.5:1 on the locked dark code background in both themes, and calculate every code-surface text token. Check title/header gradients too, plus copy buttons. Capture desktop/mobile screenshots in dark and light themes and run the site chrome guard. Keep the change within code-surface tokens; coordinate other page contrast with #683.

    Existing pair computes to 3.801:1. Rendered browser QA will be needed in the eventual PR.

    Run the focused tests:

    pytest tests/test_check_site_chrome_parity.py --no-cov

    Run these guards/checks as applicable to the changed files:

    ruff format --check tests/test_check_site_chrome_parity.py
    ruff check tests/test_check_site_chrome_parity.py
    python3 tools/check_site_chrome_parity.py
    python3 tools/check_site_claims.py --strict

    If user-facing documentation changes, update the existing Turkish mirror in the same PR; keep commands, code and terminal output in English and structurally aligned. English-only contributor standards need no new mirror.

    Open the PR against development with Fixes #887 once every finding is resolved or explicitly closed with a reason; use Refs #887 for partial work and list the resolved finding IDs.

  3. added a commit that references this issue on Oct 17, 2026
    48aa82e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: siteCode area: sitebugSomething isn't workinggood first issueGood for newcomersseverity: lowMinor defect, inaccuracy or rough edgesource: review-2026-09Found by the September 2026 independent reviewwave: 4Roadmap wave 4: low / info / watch, when touching the module

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions