Skip to content

[Wave 4] Low/info — TR mirror: docs/usermanuals/en/data/ (part 2/2) #814

Open

Description

@cemililik

Wave 4 · 4 finding(s) in 4 fix package(s). Mirror drift across small document pairs in this directory.

Findings

  • DOC-TR12-067 (TR mirror, Low) — TR mirror drift in docs/usermanuals/en/data/secrets.md: ✓ masked 47 secrets: aws_access_key: 12 ... ; languages (top-3): en=8400
    severity Low
    Where. EN docs/usermanuals/en/data/secrets.md:35-40,66 · TR docs/usermanuals/tr/data/secrets.md:35-40,66
    English text. ✓ masked 47 secrets: aws_access_key: 12 ... ; languages (top-3): en=8400
    Turkish text. ✓ 47 sır maskelendi: ... ; languages (top-3): en=8400
    Which is correct. Neither.
    Proposed correction (Turkish text for the -tr page). Note : Secrets masking redacted 47 credential span(s): aws_access_key=12, github_token=8, ...; dil satırında en fazla 200'lük örneklem toplamı (ör. en=200).

  • DOC-TR12-068 (TR mirror, Low) — TR mirror drift in docs/usermanuals/en/data/secrets.md: aws_access_key requires the literal AKIA prefix
    severity Low
    Where. EN docs/usermanuals/en/data/secrets.md:111 · TR docs/usermanuals/tr/data/secrets.md:111
    English text. aws_access_key requires the literal AKIA prefix
    Turkish text. aws_access_key düz AKIA ön-ekini ... şart koşar
    Which is correct. AKIA or ASIA.
    Proposed correction (Turkish text for the -tr page). aws_access_key, AKIA veya ASIA ön-ekini ve ardından 16 büyük harf/rakam şart koşar

  • DOC-TR12-069 (TR mirror, Low) — TR mirror drift in docs/usermanuals/en/data/synthetic-data.md: system_prompt: "" # optional — prepended on every call
    severity Low
    Where. EN docs/usermanuals/en/data/synthetic-data.md:31 · TR docs/usermanuals/tr/data/synthetic-data.md:31
    English text. system_prompt: "" # optional — prepended on every call
    Turkish text. opsiyonel — her çağrının başına eklenir
    Which is correct. Empty means the default 'You are a helpful assistant.' is sent.
    Proposed correction (Turkish text for the -tr page). # boş bırakılırsa teacher'a varsayılan "You are a helpful assistant." gönderilir; doluysa her çağrıda kullanılır

  • DOC-TR12-070 (TR mirror, Low) — TR mirror drift in docs/usermanuals/en/data/synthetic-data.md: [..] generating from gpt-4o / 100/ / ✓ wrote rows
    severity Low
    Where. EN docs/usermanuals/en/data/synthetic-data.md:48-51 · TR docs/usermanuals/tr/data/synthetic-data.md:48-51
    English text. [..] generating from gpt-4o / 100/ / ✓ wrote rows
    Turkish text. gpt-4o'dan üretim / 100/ / ✓ ... satır yazıldı
    Which is correct. Neither.
    Proposed correction. Starting synthetic data generation: 120 prompts, teacher=gpt-4o, backend=api ... Synthetic data saved: data/synthetic.jsonl (118 entries, 98.3% success rate).

Done when

  • Every finding above is fixed or closed with a reason (tick it here).
  • Code fixes carry a test; doc fixes update the Turkish mirror in the same PR.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Activity

  1. added
    documentationImprovements or additions to documentation
    i18nEnglish/Turkish documentation mirror
    severity: lowMinor defect, inaccuracy or rough edge
    source: review-2026-10Found by the October 2026 code and documentation review
    wave: 4Roadmap wave 4: low / info / watch, when touching the module
    on Oct 9, 2026
  2. cemililik commented on Oct 11, 2026

    @cemililik
    CollaboratorAuthor

    Where to start

    Thanks for taking a look. Please confirm the issue is unassigned and comment before starting so work does not overlap.

    Start with these files on development:

    Replace invented terminal output with clearly described behavior or unedited real captures; language counts are from at most 200 sampled texts. Document AKIA or ASIA and that an empty API/local teacher system prompt uses the default helpful-assistant message. Keep terminal output in English in both mirrors. Resolve all four listed IDs without adding detector rules.

    Coordinate with #611: the same two manual pairs are touched.

    Run the focused tests:

    pytest tests/test_data_audit_phase12.py tests/test_synthetic.py --no-cov

    Run these guards/checks as applicable to the changed files:

    ruff format --check forgelm/ingestion.py forgelm/synthetic.py forgelm/data_audit/_streaming.py tests/test_data_audit_phase12.py tests/test_synthetic.py
    ruff check forgelm/ingestion.py forgelm/synthetic.py forgelm/data_audit/_streaming.py tests/test_data_audit_phase12.py tests/test_synthetic.py
    python3 tools/check_bilingual_parity.py --strict
    python3 tools/check_bilingual_code_blocks.py --strict
    python3 tools/check_anchor_resolution.py --strict
    python3 tools/check_tr_links_prefer_mirror.py --strict
    python3 tools/check_usermanual_self_contained.py --strict
    python3 tools/check_usermanual_schema_drift.py --strict

    If user-facing documentation changes, update the existing Turkish mirror in the same PR; keep commands, code and terminal output in English and structurally aligned. English-only contributor standards need no new mirror.

    Open the PR against development with Fixes #814 once every finding is resolved or explicitly closed with a reason; use Refs #814 for partial work and list the resolved finding IDs.

  3. added
    help wantedExtra attention is needed
    and removed on Oct 15, 2026
  4. cemililik commented on Oct 15, 2026

    @cemililik
    CollaboratorAuthor

    I'm removing good first issue here and marking this help wanted: it needs natural Turkish written or reviewed by a native or near-native speaker. docs/standards/localization.md does not accept unreviewed machine translation (see its "No machine-translation output" rule), so please only claim this issue if that describes you, and say in the PR who reviewed the Turkish text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationhelp wantedExtra attention is neededi18nEnglish/Turkish documentation mirrorseverity: lowMinor defect, inaccuracy or rough edgesource: review-2026-10Found by the October 2026 code and documentation reviewwave: 4Roadmap wave 4: low / info / watch, when touching the module

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions