Skip to content

[Wave 4] Low/info — TR mirror: docs/guides/ingestion.md #800

Open

Description

@cemililik

Wave 4 · 7 finding(s) in 7 fix package(s). English/Turkish mirror drift for this document pair; fix the side the finding names.

Findings

  • DOC-TR07-007 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: Phase trail: 11 pipeline, 11.5 token-aware + PDF dedup, 12 markdown + secrets + DOCX tables, 12.5 --all-mask, consolidated into v0.5.0.
    severity Low
    Where. EN docs/guides/ingestion.md:3-22 (phase trail blockquote, 'Earlier phase boundaries kept inline as breadcrumbs') · TR docs/guides/ingestion-tr.md:3-13
    English text. Phase trail: 11 pipeline, 11.5 token-aware + PDF dedup, 12 markdown + secrets + DOCX tables, 12.5 --all-mask, consolidated into v0.5.0.
    Turkish text. (blockquote absent; intro lists the same features without the --all-mask shorthand history)
    Which is correct. No substantive conflict; EN only has more detail.
    Proposed correction. Optional: add the 'Faz izi' blockquote for structural parity.

  • DOC-TR07-008 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: xxhash's absence silently falls back to hashlib.blake2b.
    severity Low
    Where. EN docs/guides/ingestion.md:33-37 · TR docs/guides/ingestion-tr.md:23-28
    English text. xxhash's absence silently falls back to hashlib.blake2b.
    Turkish text. (sentence omitted)
    Which is correct. EN (verified: data_audit/_simhash.py:55-82 blake2b fallback; xxhash is in the ingestion extra at pyproject.toml:141-148).
    Proposed correction (Turkish text for the -tr page). Ekleyin: 'xxhash yoksa simhash digest'i sessizce hashlib.blake2b'ye döner.'

  • DOC-TR07-009 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: Three example commands only.
    severity Low
    Where. EN docs/guides/ingestion.md:47-52 (three-command example block) · TR docs/guides/ingestion-tr.md:38-49
    English text. Three example commands only.
    Turkish text. Adds a fourth example: forgelm ingest ./engineering_wiki/ --recursive --strategy markdown --chunk-size 600 --secrets-mask --pii-mask --output data/wiki.jsonl, and TR example chunk text is a Turkish translation.
    Which is correct. Both valid; check_bilingual_code_blocks parity should flag it.
    Proposed correction. Add the same example to EN (or remove from TR) for code-block parity; command is valid (all flags in the CLI reference).

  • DOC-TR07-010 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: markdown (Phase 12) ... keeps code-fenced blocks atomic ...
    severity Low
    Where. EN docs/guides/ingestion.md:73 · TR docs/guides/ingestion-tr.md:71
    English text. markdown (Phase 12) ... keeps code-fenced blocks atomic ...
    Turkish text. ... fenced kod bloklarını (``` veya ~~~) atomik tutar ... Non-overlapping (sections are atomic).
    Which is correct. TR claims are correct: ~~~ fences parsed in ingestion.py:_parse_md_fence 1555-1594; overlap rejected for markdown (ingestion.py:~99, ~2362).
    Proposed correction (Turkish text for the -tr page). Add to EN: 'tilde (~~~) fences are also honoured; --overlap/--overlap-tokens are rejected for markdown'. Translate the English fragment in TR: 'Çakışmasız (bölümler atomiktir).'

  • DOC-TR07-011 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: Detected categories ... OpenSSH/RSA/DSA/EC/PGP private-key block headers ...; ingest_path() masking delegates to forgelm.data_audit.mask_secrets (9 prefix…
    severity Low
    Where. EN docs/guides/ingestion.md:117-121 and :132-139 · TR docs/guides/ingestion-tr.md:129-139
    English text. Detected categories ... OpenSSH/RSA/DSA/EC/PGP private-key block headers ...; ingest_path() masking delegates to forgelm.data_audit.mask_secrets (9 prefix-anchored patterns).
    Turkish text. Detector dar bir prefix-anchored regex seti kullanır ...; tam OpenSSH / RSA / DSA / EC / PGP private-key blokları (BEGIN'den END'e kadar tüm gövde redact edilir) ... (no mention of 9 patterns or the mask_secrets delegation).
    Which is correct. TR is correct on block vs header (_secrets.py openssh_private_key/pgp_private_key patterns match BEGIN..END); EN contradicts itself. 9 patterns verified (SECRET_TYPES has 9 entries, _secrets.py:~22-32).
    Proposed correction. Fix EN to 'full private-key blocks'. Optionally add to TR: 'ingest_path() maskelemesi forgelm.data_audit.mask_secrets'e devreder (9 prefix-anchored pattern).'

  • DOC-TR07-012 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: Only the --output-format json paragraph.
    severity Low
    Where. EN docs/guides/ingestion.md:254-263 · TR docs/guides/ingestion-tr.md:253-268
    English text. Only the --output-format json paragraph.
    Turkish text. TR adds a paragraph first: '--strategy markdown (Faz 12) heading-aware splitter'ı seçer ... --secrets-mask ... [REDACTED-SECRET] ile değiştirir.'
    Which is correct. Both consistent with code (replacement default '[REDACTED-SECRET]' in _secrets.py:mask_secrets).
    Proposed correction. Add the same paragraph to EN or remove from TR; content verified correct.

  • DOC-TR07-013 (TR mirror, Low) — TR mirror drift in docs/guides/ingestion.md: left the deeper constant line stranded in 74 / 82 chunks on the audit's pilot corpus.
    severity Low
    Where. EN docs/guides/ingestion.md:293-296 · TR docs/guides/ingestion-tr.md:298-301
    English text. left the deeper constant line stranded in 74 / 82 chunks on the audit's pilot corpus.
    Turkish text. audit'in 2026-05-11 pilot corpus'unda 74 / 82 chunk'a sızan sabit kimlik satırını
    Which is correct. Date 2026-05-11 matches a code comment (ingestion.py:~258 'The audit (§1.1, 2026-05-11)'), so it is supported, but it points at an internal audit note; EN omits it.
    Proposed correction. Remove the date or keep identical in both languages; the date appears only in TR.

Done when

  • Every finding above is fixed or closed with a reason (tick it here).
  • Code fixes carry a test; doc fixes update the Turkish mirror in the same PR.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationi18nEnglish/Turkish documentation mirrorseverity: lowMinor defect, inaccuracy or rough edgesource: review-2026-10Found by the October 2026 code and documentation reviewwave: 4Roadmap wave 4: low / info / watch, when touching the module

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions