Skip to content

[Wave 3] Medium — Docs: docs/usermanuals/tr/training/ #620

Open

Description

@cemililik

Wave 3 · 1 finding(s) in 1 fix package(s). Documents with fewer than five findings each in this wave, grouped by directory.

Findings

  • DOC-BNEG-010 (docs, Medium) — docs/usermanuals/tr/training/distributed.md: false claim — model.py:560-561 dispatches to _load_unsloth (280-340), which has no try/fallback, so FastLanguageModel errors propagate. The 'supported fam…
    severity Medium
    Where. docs/usermanuals/tr/training/distributed.md:59 · type: false claim
    The document says. Mimariniz desteklenmiyorsa ForgeLM uyarı bırakır ve standart backend'e döner
    What the code does. model.py:560-561 dispatches to _load_unsloth (280-340), which has no try/fallback, so FastLanguageModel errors propagate. The 'supported families' are not listed in the TR configuration reference.

Done when

  • Every finding above is fixed or closed with a reason (tick it here).
  • Code fixes carry a test; doc fixes update the Turkish mirror in the same PR.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Activity

  1. added
    documentationImprovements or additions to documentation
    severity: mediumReal defect with limited reach or a workaround
    source: review-2026-10Found by the October 2026 code and documentation review
    wave: 3Roadmap wave 3: medium severity, module sweeps
    on Oct 9, 2026
  2. cemililik commented on Oct 11, 2026

    @cemililik
    CollaboratorAuthor

    Where to start

    Thanks for taking a look. Please confirm the issue is unassigned and comment before starting so work does not overlap.

    Start with these files on development:

    State that selecting the Unsloth backend uses its loader and propagates load errors. Remove the warning-and-automatic-fallback promise from both languages. Explain choosing the standard backend explicitly without promising architecture support.

    Run the focused tests:

    pytest tests/test_model.py --no-cov

    Run these guards/checks as applicable to the changed files:

    ruff format --check forgelm/model.py tests/test_model.py
    ruff check forgelm/model.py tests/test_model.py
    python3 tools/check_bilingual_parity.py --strict
    python3 tools/check_bilingual_code_blocks.py --strict
    python3 tools/check_anchor_resolution.py --strict
    python3 tools/check_tr_links_prefer_mirror.py --strict
    python3 tools/check_usermanual_self_contained.py --strict
    python3 tools/check_usermanual_schema_drift.py --strict

    If user-facing documentation changes, update the existing Turkish mirror in the same PR; keep commands, code and terminal output in English and structurally aligned. English-only contributor standards need no new mirror.

    Open the PR against development with Fixes #620 once every finding is resolved or explicitly closed with a reason; use Refs #620 for partial work and list the resolved finding IDs.

  3. added
    help wantedExtra attention is needed
    i18nEnglish/Turkish documentation mirror
    and removed on Oct 15, 2026
  4. cemililik commented on Oct 15, 2026

    @cemililik
    CollaboratorAuthor

    I'm removing good first issue here and marking this help wanted: it needs natural Turkish written or reviewed by a native or near-native speaker. docs/standards/localization.md does not accept unreviewed machine translation (see its "No machine-translation output" rule), so please only claim this issue if that describes you, and say in the PR who reviewed the Turkish text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationhelp wantedExtra attention is neededi18nEnglish/Turkish documentation mirrorseverity: mediumReal defect with limited reach or a workaroundsource: review-2026-10Found by the October 2026 code and documentation reviewwave: 3Roadmap wave 3: medium severity, module sweeps

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions