Repository navigation
[Wave 3] Medium — Module sweep: Training orchestration, multi-stage pipelines, resume & no-train modes (part 2/2) #572
Description
Wave 3 · 2 finding(s) in 1 fix package(s). Fix these whenever a pull request touches this module ("clean the module you touch").
Findings
-
CR-A04-050 (code, Low) — Dry-run 'dora' field reads the deprecated use_dora flag and reports false for lora.method: dora
severity Low · reachabilitydefault· intentcontract-violation· confidence likely · independently confirmed · reproduced end to end · already tracked: KNOWN-OPEN C31-RUN-OUTCOME — docs/roadmap/phase-16-trust-surface-hardening.md:522-525 (S8 open)
Failure scenario. An operator verifying that DoRA is enabled via dry-run (text or JSON envelope) is told it is not.
Where.forgelm/cli/_dry_run.py:53(confirmed),forgelm/config.py:390-439,forgelm/model.py:238-240,docs/usermanuals/en/reference/json-output.md:100
Recommended fix. Use model._resolve_peft_flags (or report lora.method). -
↳ same root cause: DOC-D3B03-011 (docs, Medium) — docs/usermanuals/en/reference/json-output.md: wrong detail — dora is the effective value of the corresponding config flag.
severity Medium · already tracked: KNOWN-OPEN C31-RUN-OUTCOME docs/roadmap/phase-16-trust-surface-hardening.md:522-525
Where.docs/usermanuals/en/reference/json-output.md:100(Turkish mirror:docs/usermanuals/tr/reference/json-output.md:100) · type: wrong detail
The document says. dora is the effective value of the corresponding config flag.
What the code does. The dry-run reads only the deprecated lora.use_dora. With the canonical lora.method: "dora", the dry-run printed "dora": false (I ran it), while training applies DoRA (use_dora = config.lora.use_dora or peft_method == 'dora').
Code references.forgelm/cli/_dry_run.py:53,forgelm/model.py:238
Proposed correction. Fix the code: "dora": config.lora.use_dora or config.lora.method == "dora". Optionally also expose lora.method in the envelope.
Turkish mirror. the Turkish page has the same error; fix both in the same PR
Done when
- Every finding above is fixed or closed with a reason (tick it here).
- Code fixes carry a test; doc fixes update the Turkish mirror in the same PR.
Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsTodo
Activity
cemililik commentedon Oct 11, 2026
Where to start
Thanks for taking a look. Please confirm the issue is unassigned and comment before starting so work does not overlap.
Start with these files on
development:Make dry-run dora agree with the effective lora.method/use_dora resolution used by model loading. Add a parametrized regression covering method=dora, ordinary LoRA and the supported legacy flag; assert the JSON result without loading a model.
Run the focused tests:
Run these guards/checks as applicable to the changed files:
If user-facing documentation changes, update the existing Turkish mirror in the same PR; keep commands, code and terminal output in English and structurally aligned. English-only contributor standards need no new mirror.
Open the PR against
developmentwithFixes #572once every finding is resolved or explicitly closed with a reason; useRefs #572for partial work and list the resolved finding IDs.cemililik commentedon Oct 15, 2026
I'm removing
good first issuehere: this finding is tracked by Phase 16 step S8 (#894), which lands as one root-cause family with its own review rounds (see "Roadmap steps" inCONTRIBUTING.md), so a separate fix could collide with it. Please don't start on it without coordinating on #894 first.