Skip to content

Manual claims forgelm audit flags chosen == rejected preference rows (with fabricated sample output); no such check exists (CR-MISC-006) #397

Open

Description

@cemililik

Wave 1 · theme D1-4: Data audit, PII/secret detection and ingestion · highest severity High · 1 finding(s) · effort small

Summary

A DPO run converges to ~0 loss because of degenerate pairs. The user follows the troubleshooting advice, runs forgelm audit, gets a clean result, and keeps the corrupted dataset.

Primary finding

CR-MISC-006 — Manual claims forgelm audit flags chosen == rejected preference rows (with fabricated sample output); no such check exists

severity High · reachability default · intent contract-violation · confidence confirmed · independently confirmed · reproduced end to end

What happens. Four EN pages and their TR mirrors promise a chosen == rejected check, including a sample output line '⚠ 12 chosen-rejected identical rows'. The audit has no format-specific checks, as data/audit.md:122 itself admits, so the docs contradict each other. The DPO troubleshooting advice (dpo.md:208) sends users to a check that cannot fire.

Where.

Evidence.

  • Audit of 16 preference rows, 8 with chosen == rejected: exit 0, and nothing in the summary or report flags them.

Recommended fix. Implement a cheap preference-pair check (exact and normalised chosen == rejected count in the report), or remove the claim and the fabricated sample output from all mirrors.

Acceptance criteria

  • A regression test reproduces the failure scenario and asserts the corrected behaviour.
  • Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
  • Every finding in this issue is resolved or explicitly closed with a reason.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: dev-toolingCode area: dev-toolingbugSomething isn't workingseverity: highWrong behaviour or a false claim users rely onsource: review-2026-10Found by the October 2026 code and documentation reviewwave: 1Roadmap wave 1: high severity, small effort

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions