Skip to content

TR mirror drift in docs/usermanuals/en/data/secrets.md: ForgeLM's PEM detector ... matches the entire block (BEGIN to END) ... avoids the common bug of detecting the BEGIN line but leaving the key bo… (DOC-TR12-007) #353

Open

Description

@cemililik

Wave 1 · theme D1-10: Documentation-only fixes · highest severity High · 1 finding(s) · effort docs fix

Summary

Neither: blocks with a body > 8192 chars (PGP > 65536), unterminated blocks and PKCS#8 / ENCRYPTED PRIVATE KEY headers are not matched, so the key body stays in the JSONL.

Primary finding

DOC-TR12-007 — TR mirror drift in docs/usermanuals/en/data/secrets.md: ForgeLM's PEM detector ... matches the entire block (BEGIN to END) ... avoids the common bug of detecting the BEGIN line but leaving the key bo…

severity High

Where. EN docs/usermanuals/en/data/secrets.md:3,43-54 · TR docs/usermanuals/tr/data/secrets.md:3,43-54

English text. ForgeLM's PEM detector ... matches the entire block (BEGIN to END) ... avoids the common bug of detecting the BEGIN line but leaving the key body

Turkish text. tüm bloğu (BEGIN'den END'e) eşleştirir ... key body'sini JSONL'da bırakan yaygın bug'ı önler

Which is correct. Neither: blocks with a body > 8192 chars (PGP > 65536), unterminated blocks and PKCS#8 / ENCRYPTED PRIVATE KEY headers are not matched, so the key body stays in the JSONL.

Proposed correction (Turkish text for the -tr page). PEM dedektörü yalnızca OPENSSH/RSA/DSA/EC başlıklı ve gövdesi en fazla 8192 karakter olan (PGP için 65536) BEGIN...END bloklarını bütün olarak maskeler. Daha büyük, END'siz veya BEGIN PRIVATE KEY (PKCS#8) biçimli bloklar tespit edilmez ve JSONL'da açık kalır; ingest sonrası forgelm audit ile doğrulayın.

Acceptance criteria

  • Each statement is re-checked against the code at fix time.
  • Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
  • Every finding in this issue is resolved or explicitly closed with a reason.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Activity

  1. added
    documentationImprovements or additions to documentation
    i18nEnglish/Turkish documentation mirror
    severity: highWrong behaviour or a false claim users rely on
    source: review-2026-10Found by the October 2026 code and documentation review
    wave: 1Roadmap wave 1: high severity, small effort
    on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationi18nEnglish/Turkish documentation mirrorseverity: highWrong behaviour or a false claim users rely onsource: review-2026-10Found by the October 2026 code and documentation reviewwave: 1Roadmap wave 1: high severity, small effort

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions