Skip to content

TR mirror drift in docs/guides/human_approval_gate.md: Gate fires after evaluation succeeds; a failing eval exits 3 and never reaches approval (DOC-TR08-004) #318

Open

Description

@cemililik

Wave 1 · theme D1-10: Documentation-only fixes · highest severity High · 1 finding(s) · effort docs fix

Summary

Neither: gate fires after eval AND benchmark, safety and judge gates pass; staging dir is written BEFORE these gates, so a failed run with auto_revert off leaves a staging dir on disk while exiting 3.

Primary finding

DOC-TR08-004 — TR mirror drift in docs/guides/human_approval_gate.md: Gate fires after evaluation succeeds; a failing eval exits 3 and never reaches approval

severity High

Where. EN docs/guides/human_approval_gate.md:15,61 · TR docs/guides/human_approval_gate-tr.md:15,61

English text. Gate fires after evaluation succeeds; a failing eval exits 3 and never reaches approval

Turkish text. Kapı eval başarılı olduktan sonra ateşlenir (başarısız eval 3 ile çıkar, onay aşamasına ulaşmaz)

Which is correct. Neither: gate fires after eval AND benchmark, safety and judge gates pass; staging dir is written BEFORE these gates, so a failed run with auto_revert off leaves a staging dir on disk while exiting 3.

Proposed correction (Turkish text for the -tr page). Kapı, eval/benchmark/safety/judge kapılarının HEPSİ geçtikten sonra devreye girer; bunlardan biri başarısız olursa çıkış kodu 3 (EXIT_EVAL_FAILURE) olur ve onay aşamasına gelinmez. Dikkat: staging dizini bu kapılardan önce yazıldığı için auto_revert kapalıysa başarısız bir koşumda da diskte final_model.staging.<run_id>/ kalabilir; bu bir onay beklemesi DEĞİLDİR.

Acceptance criteria

  • Each statement is re-checked against the code at fix time.
  • Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
  • Every finding in this issue is resolved or explicitly closed with a reason.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Activity

  1. added
    documentationImprovements or additions to documentation
    i18nEnglish/Turkish documentation mirror
    severity: highWrong behaviour or a false claim users rely on
    source: review-2026-10Found by the October 2026 code and documentation review
    wave: 1Roadmap wave 1: high severity, small effort
    on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationi18nEnglish/Turkish documentation mirrorseverity: highWrong behaviour or a false claim users rely onsource: review-2026-10Found by the October 2026 code and documentation reviewwave: 1Roadmap wave 1: high severity, small effort

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions