You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TR mirror drift in docs/guides/human_approval_gate.md: Gate fires after evaluation succeeds; a failing eval exits 3 and never reaches approval (DOC-TR08-004) #318
Neither: gate fires after eval AND benchmark, safety and judge gates pass; staging dir is written BEFORE these gates, so a failed run with auto_revert off leaves a staging dir on disk while exiting 3.
Primary finding
DOC-TR08-004 — TR mirror drift in docs/guides/human_approval_gate.md: Gate fires after evaluation succeeds; a failing eval exits 3 and never reaches approval
English text. Gate fires after evaluation succeeds; a failing eval exits 3 and never reaches approval
Turkish text. Kapı eval başarılı olduktan sonra ateşlenir (başarısız eval 3 ile çıkar, onay aşamasına ulaşmaz)
Which is correct. Neither: gate fires after eval AND benchmark, safety and judge gates pass; staging dir is written BEFORE these gates, so a failed run with auto_revert off leaves a staging dir on disk while exiting 3.
Proposed correction (Turkish text for the -tr page). Kapı, eval/benchmark/safety/judge kapılarının HEPSİ geçtikten sonra devreye girer; bunlardan biri başarısız olursa çıkış kodu 3 (EXIT_EVAL_FAILURE) olur ve onay aşamasına gelinmez. Dikkat: staging dizini bu kapılardan önce yazıldığı için auto_revert kapalıysa başarısız bir koşumda da diskte final_model.staging.<run_id>/ kalabilir; bu bir onay beklemesi DEĞİLDİR.
Acceptance criteria
Each statement is re-checked against the code at fix time.
Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
Every finding in this issue is resolved or explicitly closed with a reason.
Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.
Activity