You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user believes names are scrubbed from the curated JSONL and trains/shares data still containing personal names - a privacy-control overclaim (rubric critical clause; rated high because the audit notes 'Regex-based detector - false negatives possible').
The document says. MASK_PII: Redact names / emails / phone numbers / IDs before writing.
What the code does.forgelm ingest --pii-mask uses the regex detector only: PII_TYPES = email, phone, credit_card, iban, tr_id, de_id, fr_ssn, us_ssn (forgelm/data_audit/_types.py:19; ingestion.py:2378-2380 imports mask_pii). Personal names are never masked; person/organization/location come only from the audit-side --pii-ml Presidio pass, which ingest does not run. Observed: with --pii-mask the runbook line 'Operator: Alice ([REDACTED], [REDACTED])' keeps the name.
User impact. A user believes names are scrubbed from the curated JSONL and trains/shares data still containing personal names - a privacy-control overclaim (rubric critical clause; rated high because the audit notes 'Regex-based detector - false negatives possible').
Proposed correction. 'Redact emails, phone numbers, card numbers, IBANs and national IDs (TR/DE/FR/US). Personal names are NOT redacted by ingest; run forgelm audit --pii-ml to detect them.' Same wording in the cell 5 comment.
Acceptance criteria
Each statement is re-checked against the code at fix time.
Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
Every finding in this issue is resolved or explicitly closed with a reason.
Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.
Fixed on development by 735a02f (#1050). In notebooks/ingestion_playground.ipynb, the MASK_PII table row and the cell-5 comment now say that only the formats the regex layer detects are masked, and that names are not. Closing as completed.
Activity
fix(docs): align GDPR, erasure, retention and PII documentation with …
cemililik commentedon Oct 22, 2026
Fixed on
developmentby 735a02f (#1050). Innotebooks/ingestion_playground.ipynb, theMASK_PIItable row and the cell-5 comment now say that only the formats the regex layer detects are masked, and that names are not. Closing as completed.