Skip to content

notebooks/ingestion_playground.ipynb: false claim — MASK_PII: Redact names / emails / phone numbers / IDs before writing. (DOC-D4B06-002) #275

Closed

Description

@cemililik

Wave 1 · theme D1-10: Documentation-only fixes · highest severity High · 1 finding(s) · effort docs fix

Summary

A user believes names are scrubbed from the curated JSONL and trains/shares data still containing personal names - a privacy-control overclaim (rubric critical clause; rated high because the audit notes 'Regex-based detector - false negatives possible').

Primary finding

DOC-D4B06-002 — notebooks/ingestion_playground.ipynb: false claim — MASK_PII: Redact names / emails / phone numbers / IDs before writing.

severity High

Where. notebooks/ingestion_playground.ipynb cell 4 (markdown table, MASK_PII row) and cell 5 (code comment 'redact PII (names, emails, phones, IDs)') · type: false claim

The document says. MASK_PII: Redact names / emails / phone numbers / IDs before writing.

What the code does. forgelm ingest --pii-mask uses the regex detector only: PII_TYPES = email, phone, credit_card, iban, tr_id, de_id, fr_ssn, us_ssn (forgelm/data_audit/_types.py:19; ingestion.py:2378-2380 imports mask_pii). Personal names are never masked; person/organization/location come only from the audit-side --pii-ml Presidio pass, which ingest does not run. Observed: with --pii-mask the runbook line 'Operator: Alice ([REDACTED], [REDACTED])' keeps the name.

Code references. forgelm/data_audit/_types.py:19, forgelm/ingestion.py:2378-2380, forgelm/data_audit/_pii_ml.py:196-200

User impact. A user believes names are scrubbed from the curated JSONL and trains/shares data still containing personal names - a privacy-control overclaim (rubric critical clause; rated high because the audit notes 'Regex-based detector - false negatives possible').

Proposed correction. 'Redact emails, phone numbers, card numbers, IBANs and national IDs (TR/DE/FR/US). Personal names are NOT redacted by ingest; run forgelm audit --pii-ml to detect them.' Same wording in the cell 5 comment.

Acceptance criteria

  • Each statement is re-checked against the code at fix time.
  • Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
  • Every finding in this issue is resolved or explicitly closed with a reason.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Activity

  1. added
    documentationImprovements or additions to documentation
    severity: highWrong behaviour or a false claim users rely on
    source: review-2026-10Found by the October 2026 code and documentation review
    wave: 1Roadmap wave 1: high severity, small effort
    on Oct 9, 2026
  2. cemililik commented on Oct 22, 2026

    @cemililik
    CollaboratorAuthor

    Fixed on development by 735a02f (#1050). In notebooks/ingestion_playground.ipynb, the MASK_PII table row and the cell-5 comment now say that only the formats the regex layer detects are masked, and that names are not. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationseverity: highWrong behaviour or a false claim users rely onsource: review-2026-10Found by the October 2026 code and documentation reviewwave: 1Roadmap wave 1: high severity, small effort

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions