Skip to content

docs/usermanuals/en/training/lora.md: broken example — target_modules: "all-linear" is a valid form ("broadest — every Linear layer"). (DOC-D3B06-011) #245

Closed

Description

@cemililik

Wave 1 · theme D1-10: Documentation-only fixes · highest severity High · 1 finding(s) · effort docs fix

Summary

An operator who copies the "broadest" option gets a config error and cannot train.

Primary finding

DOC-D3B06-011 — docs/usermanuals/en/training/lora.md: broken example — target_modules: "all-linear" is a valid form ("broadest — every Linear layer").

severity High

Where. docs/usermanuals/en/training/lora.md:97 (Turkish mirror: docs/usermanuals/tr/training/lora.md:95) · type: broken example

The document says. target_modules: "all-linear" is a valid form ("broadest — every Linear layer").

What the code does. LoraConfigModel.target_modules is typed List[str] (forgelm/config.py:384-387) with extra=forbid and no string coercion. A scratch config with target_modules: "all-linear" fails --dry-run with lora.target_modules Input should be a valid list [type=list_type] (exit 1, run in this audit).

Code references. forgelm/config.py:384-387

User impact. An operator who copies the "broadest" option gets a config error and cannot train.

Proposed correction. Delete the "all-linear" line, or write it as a list. Add: "target_modules must be a YAML list; the PEFT shorthand string all-linear is rejected by the schema."

Turkish mirror. the Turkish page has the same error; fix both in the same PR

Acceptance criteria

  • Each statement is re-checked against the code at fix time.
  • Documentation listed above is corrected in English and in its Turkish mirror in the same PR.
  • Every finding in this issue is resolved or explicitly closed with a reason.

Found by the October 2026 ForgeLM code and documentation review against commit cab2947. Code links point at that commit; line numbers may have moved since. Finding IDs (CR-…, DOC-…, TECH-…) are stable references for this backlog.

Activity

  1. added
    documentationImprovements or additions to documentation
    severity: highWrong behaviour or a false claim users rely on
    source: review-2026-10Found by the October 2026 code and documentation review
    wave: 1Roadmap wave 1: high severity, small effort
    on Oct 9, 2026
  2. cemililik commented on Oct 22, 2026

    @cemililik
    CollaboratorAuthor

    Fixed on development by 735a02f (#1050). docs/usermanuals/en/training/lora.md and its Turkish mirror now show target_modules as a list and state that the string "all-linear" is not accepted; the schema still rejects it. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationseverity: highWrong behaviour or a false claim users rely onsource: review-2026-10Found by the October 2026 code and documentation reviewwave: 1Roadmap wave 1: high severity, small effort

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions