fix(tui): require deliberate approval dialog input - #6755
Merged
Merged
Conversation
Start elevation at Abort; require unmodified navigation or a visible row click. Ignore stale, modified, repeated and release-key answers through the existing view timestamp and keybinding authorities. Keep all offered elevation choices visible in compact dialogs. Validation: 25 focused Rust tests passed, 0 failed, 0 ignored; npm test 636 passed; npm run check:web passed. Formatting and diff checks passed. Initial Rust compile caught an unfulfilled dead_code expectation; the annotation was corrected before the passing retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No-Issue: verified approval-dialog input handling findings from the current audit.
Elevation dialogs can receive typing that began before they opened, and their default selection previously permitted a grant. Start on Abort, ignore stale/modified/non-press keys, and require deliberate unmodified navigation plus Enter or a click on an offered row. The existing view timestamp gate and keybinding table govern both approval dialog kinds; compact rendering retains all choices and controls.
Validation: 25 focused Rust tests passed (0 failed, 0 ignored), including stale input, modifier/repeat handling, six render sizes, mouse choices, localization and existing approval shortcuts.
npm test: 636 passed;npm run check:web: passed. Independent source review, formatting and diff checks passed. The first Rust compile exposed an unfulfilled dead-code expectation; it was corrected before the successful retry. Hosted cross-platform checks remain required.