Skip to content

2019 auto path practice - #129

Draft
MangoSwirl wants to merge 3 commits into
masterfrom
2019
Draft

2019 auto path practice#129
MangoSwirl wants to merge 3 commits into
masterfrom
2019

Conversation

@MangoSwirl

Copy link
Copy Markdown
Member
  • add stealing and other stuff ?
  • change background and locations
  • auto

@MangoSwirl MangoSwirl left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Leo! Obviously this is a practice excersise so we don't have to get perfectly close to a publishable implementation but I think it would be helpful to get a bit closer than we are currently. Let me know if there's anything I can do to help.

Comment thread lib/metrics.dart

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional note: I don't think you meant to include these changes on this branch. not super impactful in this particular case but just to be careful, it's worth double-checking your changes before you commit and what branch you're making a new one off of

Comment on lines 385 to +388
childBuilder: (context, teamColor, isHighlighted) =>
inventory.isEmpty ? Container() : inventory.last.icon(),
inventory.isEmpty
? Container(child: Text("f"))
: inventory.last.icon(),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically when we've had games where multiple piece types can be in posession (like 2023) we've had both display in a row instead of just the most recent one.

Assuming the "f" wasn't mean to be left in.

Comment on lines +770 to +772
return inventoryAtTimestamp(timestamp)
.map((a) => PositionedGamePiece(a, positionAtTimestamp(timestamp)))
.toList();

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gamePiecePositionsAtTimestamp method is meant to return only PositionedGamePieces on the field, not in a robot, since showing the robot's inventory is already handled in animatedPath (line 385)

extension GamePieceExtension on GamePiece {
Widget icon(
{Color color = const Color.from(alpha: 1, red: 1, green: 1, blue: 1)}) {
Widget icon({Color color = const Color.fromARGB(255, 244, 163, 0)}) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random design note: for some reason we've always used white for the game piece icon color, regardless of its actual color irl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants