Fix: Show sales ended state on past event pages - #1334
Merged
Conversation
|
🚅 Deployed to the Hi.Events-pr-1334 environment in Hi.Events
1 service not affected by this PR
|
railway-app
Bot
temporarily deployed
to
Hi.Events / Hi.Events-pr-1334
September 3, 2026 19:47
Destroyed
Contributor
✅ E2E · smoke
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1332
The event page hero badge ignored whether sales had ended, and
lifecycle_statuswas reported asUPCOMINGfor recurring events whose dates had all passed (past occurrences are filtered out of the public payload). Past events now show a "Sales ended" badge and drop the floating get-tickets button.Covered by unit tests and a new E2E spec for past single and recurring events.
🤖 Generated with Claude Code