[xgo-work]

Fixes the refId change that occured when a scenario was patched and exported again directly

[TehAwol]

Should we also expand this to propagation ?

[xgo-work]

Should we also expand this to propagation ?

Good question, I don't remember having this issue with models but I will dig into that

[xgo-work]

Following our discussion on slack :
If a model variable x changed refId (R1 → R2), the diff would read "delete x(R1), create x(R2)". Every scenario would replace its x instead of merging it, losing the scenarist's edited content on INHERITED & PROTECTED variables.
We should rather plan an early fail, but that is out of scope.

[TehAwol]

Suggested change

	public void setDependsOnStrategy(DependsOnStrategy dependsOnStrategy) {
	this.dependsOnStrategy = dependsOnStrategy == null ? DependsOnStrategy.AUTO : dependsOnStrategy;
	}

Ensure dependsOnStrategy can never be null and resolves to AUTO by default (certain older scenarios may have this)

[xgo-work]

I am dubitative, setDependsOnStrategy in TriggerDescriptor has only one caller in a test with a constant
manual.setDependsOnStrategy(AbstractTransition.DependsOnStrategy.MANUAL);