Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This dependent draft adds the customer-owned S3/R2 delivery implementation to PR #28 and closes all six findings from the scoped hosted-storage security review:
Hosted mode remains fail closed. Self-hosted recording behavior is unchanged. This PR does not merge, deploy, or enable customer storage.
Verification
Remaining integration proof
The public contract is aligned with the private storage adapter work. Live AWS S3 and Cloudflare R2 end-to-end tests remain required before storage is enabled. This draft intentionally targets PR #28 so review can happen without merging or deployment.