Skip to content

Fix column families not receiving tuned settings #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Havret merged 1 commit into from
Jul 14, 2026
Merged

Fix column families not receiving tuned settings #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/RocksDb.Extensions/RocksDbContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ internal class RocksDbContext : IDisposable
private readonly WriteOptions _writeOptions;
private readonly Dictionary<string, MergeOperatorConfig> _mergeOperators;
private readonly Cache _cache;
private readonly BlockBasedTableOptions _tableConfig;

// ReSharper disable once CollectionNeverQueried.Local
/// <summary>
Expand All @@ -19,7 +20,7 @@ internal class RocksDbContext : IDisposable
/// </summary>
private readonly Dictionary<string, ColumnFamilyOptions> _columnFamilyOptions = new();

private const long BlockCacheSize = 50 * 1024 * 1024L;
private const long BlockCacheSize = 64 * 1024 * 1024L;
private const long BlockSize = 4096L;
private const long WriteBufferSize = 16 * 1024 * 1024L;
private const int MaxWriteBuffers = 3;
Expand All @@ -44,19 +45,14 @@ public RocksDbContext(IOptions<RocksDbOptions> options)
dbOptions.SetUseDirectReads(options.Value.UseDirectReads);
dbOptions.SetUseDirectIoForFlushAndCompaction(options.Value.UseDirectIoForFlushAndCompaction);
dbOptions.EnableStatistics();
dbOptions.SetMaxWriteBufferNumber(MaxWriteBuffers);
dbOptions.SetWriteBufferSize(WriteBufferSize);
dbOptions.SetCompression(Compression.No);
dbOptions.SetCompactionStyle(Compaction.Universal);

var tableConfig = new BlockBasedTableOptions();
tableConfig.SetBlockCache(_cache);
tableConfig.SetBlockSize(BlockSize);
_tableConfig = new BlockBasedTableOptions();
_tableConfig.SetBlockCache(_cache);
_tableConfig.SetBlockSize(BlockSize);
_tableConfig.SetCacheIndexAndFilterBlocks(true);

var filter = BloomFilterPolicy.Create();
tableConfig.SetFilterPolicy(filter);

dbOptions.SetBlockBasedTableFactory(tableConfig);
_tableConfig.SetFilterPolicy(filter);

_writeOptions = new WriteOptions();
_writeOptions.DisableWal(1);
Expand Down Expand Up @@ -90,6 +86,13 @@ public ColumnFamilyOptions CreateColumnFamilyOptions(string columnFamilyName)
_columnFamilyOptions.Remove(columnFamilyName);

var cfOptions = new ColumnFamilyOptions();

cfOptions.SetBlockBasedTableFactory(_tableConfig);
cfOptions.SetMaxWriteBufferNumber(MaxWriteBuffers);
cfOptions.SetWriteBufferSize(WriteBufferSize);
cfOptions.SetCompression(Compression.No);
cfOptions.SetCompactionStyle(Compaction.Universal);

if (_mergeOperators.TryGetValue(columnFamilyName, out var mergeOperatorConfig))
{
var mergeOp = global::RocksDbSharp.MergeOperators.Create(
Expand Down
Loading