Repository navigation
refactor(components): remove unused pagination props from SimpleBrowseDataTable - #1793
Merged
Merged
Conversation
…eDataTable totalPages, totalRecords, paginationState, and setPagination were declared on BrowseDataTableProps but never destructured or read by the component. No call site passes any of them. Dispatch-Task: studio-simplebrowse-dead-props Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ba1jKDjhVgZN53tPhRvWgT
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the SimpleBrowseDataTable component by removing pagination-related properties (totalPages, totalRecords, paginationState, and setPagination) and their unused imports (PaginationState, Dispatch, and SetStateAction) from the BrowseDataTableProps interface. There are no review comments, and I have no feedback to provide.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
dawsontoth
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
SimpleBrowseDataTable's prop interface (src/components/SimpleBrowseDataTable.tsx:11-19) declared four props —totalPages,totalRecords,paginationState,setPagination— that the component body never destructures or reads. No caller passes any of them.💡 Solution
Removed the four dead props from
BrowseDataTableProps, and the now-unusedPaginationState,Dispatch,SetStateActionimports that only served them. No behavior change — the component's implementation was already ignoring these props.✅ Verification
tsc -b: zero new errors (3 pre-existing, unrelated monaco-editor type-resolution errors reproduce identically on unmodifiedstagein this worktree).oxlint: clean.vitest:SimpleBrowseDataTable.test.tsxpasses; full suite 3663/3674 passing (11 skipped) — one cross-test WebSocket-mock leak in an unrelated file (ErrorComponent.test.tsxone run, a different file the next) is pre-existing full-suite flake, not caused by this change.Refs studio-simplebrowse-dead-props
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ba1jKDjhVgZN53tPhRvWgT
Related PRs: none found
Origin — the dispatch brief this PR was written from
Remove unused props from SimpleBrowseDataTable
On studio's default branch
stage(d066a79),src/components/SimpleBrowseDataTable.tsx(~:10-17) declares four props that the component never reads:totalPages,totalRecords,paginationState,setPagination. Remove them from the props type and from every call site (grep), and confirm typecheck, lint and tests pass. Target the PR atstage.Acceptance
Props removed; tsc/lint/tests green.
Dispatch: task
studio-simplebrowse-dead-props· queued by finding-triage/wave-29 · ran by claude/sonnet/xhigh · worker kzyp-xps-1Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,cursor-kimi,cursor-muse; rounds=1; full=1 @ 687c498
Review-Attention: skim ~1m @ 687c498