Skip to content

refactor(components): remove unused pagination props from SimpleBrowseDataTable - #1793

Merged
dawsontoth merged 1 commit into
stagefrom
refactor/simple-browse-table-dead-props
Oct 8, 2026
Merged

dawsontoth merged 1 commit into
stagefrom
refactor/simple-browse-table-dead-props

Conversation

@kriszyp

@kriszyp kriszyp commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

⊙ Problem

SimpleBrowseDataTable's prop interface (src/components/SimpleBrowseDataTable.tsx:11-19) declared four props — totalPages, totalRecords, paginationState, setPagination — that the component body never destructures or reads. No caller passes any of them.

❓ Your call: as specified, yes — grepped all 10 production call sites plus the test file; none passes these props, none spreads props into the component, and the totalPages/totalRecords hits elsewhere in the repo belong to the unrelated server-paged TableView/TablePagination components, not this one.

💡 Solution

Removed the four dead props from BrowseDataTableProps, and the now-unused PaginationState, Dispatch, SetStateAction imports that only served them. No behavior change — the component's implementation was already ignoring these props.

✅ Verification

  • tsc -b: zero new errors (3 pre-existing, unrelated monaco-editor type-resolution errors reproduce identically on unmodified stage in this worktree).
  • oxlint: clean.
  • vitest: SimpleBrowseDataTable.test.tsx passes; full suite 3663/3674 passing (11 skipped) — one cross-test WebSocket-mock leak in an unrelated file (ErrorComponent.test.tsx one run, a different file the next) is pre-existing full-suite flake, not caused by this change.
  • Independent pre-push review (codex graded + gemini + cursor-composer + Harper domain adjudication): zero findings, LGTM.

Refs studio-simplebrowse-dead-props

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ba1jKDjhVgZN53tPhRvWgT

Related PRs: none found

Origin — the dispatch brief this PR was written from

Remove unused props from SimpleBrowseDataTable

On studio's default branch stage (d066a79), src/components/SimpleBrowseDataTable.tsx (~:10-17) declares four props that the component never reads: totalPages, totalRecords, paginationState, setPagination. Remove them from the props type and from every call site (grep), and confirm typecheck, lint and tests pass. Target the PR at stage.

Acceptance

Props removed; tsc/lint/tests green.

Dispatch: task studio-simplebrowse-dead-props · queued by finding-triage/wave-29 · ran by claude/sonnet/xhigh · worker kzyp-xps-1

Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,cursor-kimi,cursor-muse; rounds=1; full=1 @ 687c498

Review-Attention: skim ~1m @ 687c498

…eDataTable

totalPages, totalRecords, paginationState, and setPagination were declared on
BrowseDataTableProps but never destructured or read by the component. No call
site passes any of them.

Dispatch-Task: studio-simplebrowse-dead-props
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ba1jKDjhVgZN53tPhRvWgT

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the SimpleBrowseDataTable component by removing pagination-related properties (totalPages, totalRecords, paginationState, and setPagination) and their unused imports (PaginationState, Dispatch, and SetStateAction) from the BrowseDataTableProps interface. There are no review comments, and I have no feedback to provide.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.53% 10099 / 14953
🔵 Statements 67.69% 10777 / 15920
🔵 Functions 60.78% 2599 / 4276
🔵 Branches 62.53% 7685 / 12289
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/SimpleBrowseDataTable.tsx 100% 90% 100% 100%
Generated in workflow #2062 for commit 687c498 by the Vitest Coverage Report Action

@kriszyp
kriszyp marked this pull request as ready for review October 8, 2026 15:57
@kriszyp
kriszyp requested a review from a team as a code owner October 8, 2026 15:57
@kriszyp
kriszyp requested a review from dawsontoth October 8, 2026 15:57
@dawsontoth
dawsontoth added this pull request to the merge queue Oct 8, 2026
Merged via the queue into stage with commit dcaeb6c Oct 8, 2026
4 checks passed
@dawsontoth
dawsontoth deleted the refactor/simple-browse-table-dead-props branch October 8, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants