Skip to content

Development: 1.6.0 - #3141

Open
ethouris wants to merge 749 commits into
masterfrom
development
Open

ethouris wants to merge 749 commits into
masterfrom
development

Conversation

@ethouris

@ethouris ethouris commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

The PR for complete review and CI. Assigned PRs:

NEED IMPLEMENTATION:

PENDING:

Comment thread srtcore/utilities.h Fixed
@sonarqubecloud

sonarqubecloud Bot commented Apr 8, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
51.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Mikolaj Malecki added 25 commits June 16, 2025 12:22
…ket from RID. Added reserved disposal for muxer. Added thread debugging for SharedMutex. Added explicit mutex init (helps identify mutex from tsan-report). Fixed twice closed sockets in tests. Added bind-delay fix for reuseaddr tests. Added temporary lock for non-reentrant srt_strerror.
… Still random fails at closing caller socket
Mikolaj Malecki and others added 30 commits March 9, 2026 15:25
* Common receiver buffer for groups

* Applied partial changes (refax) from dev-rework-receiver-unit. Still use-after-free for closed members

* Applied changes for the new Receiver Unit Pool (dead now). Minor comment fixes. Fixed update prevention after dispatching shutdown

* Changed condensation to two-pointers. Extracted comments into docs

* Fixed: the incoming data packet is passed after removal from the pool. The pool is potentially required to pick up new units by packet filter. The unit is put back to the series if the buffer didn't eat it up

* Cleanup CodeQL findings

* Codespell fixes

* Improvements for BONDING enabler, Windows compiling and portability

* Improved fixes for Windows

* Added document for new unit pool

* Added intermediate treats-based type for MSVC intrinsics

* Fixed const pointer cast problem for intrinsics for pointers

* Minor fixes + codespell ignore tests

* Fixed unused warning. Fixed one more const in windows intrinsics

* Fixed usage of unused variable

* Fixed usage of unused static function. Configured POSIX-based CI to keep going

* Minor fixes. Forced using unit pool if bonding enabled

* Moved read-side CPacketUnitPool container as 'hand' container inside. Removed the unit tracking code. Fixed UT

* Cleared warnings reported in CI

* Fixed incorrectly fixed API docs

* Added some data race prevention

* Fixed bug: resize condenser only to the number of copied units. Fixed some thread-san problems.

* Fixed Windows and Mac build break

* Attempting to fix sign-compare-error on Mac

* Update receiver-buffer.md

* Reviewed CPacketUnitPool description and adjusting to new design

* Spellcheck fixes. Fixes for C++03 compatibility

* Minor unused code cleanup

---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* Extracted CiBuffer from CRcvBuffer. Removed offset-dep from CSndBuffer. Put CSndLossList to CSndBuffer. Explicit save/restore for SndRateMeasurement

* Added alternative sender buffer

* Implemented per-packet busy flags and locker object for sending packets

* [BUG] Fixed std::shared_mutex usage for C++17. Removed external clone of std::any.

* Logging: no passing string by value. Removed verbose entries for RcvBuffer test

* Unified rexmit extraction. Removed old implementation

* Added some data race prevention

* Deleted unused snd-loss-list. Withdrawn restructurization of CRcvBuffer

* Removed forced seq parameter from packLostData

* Moved encryption to the app thread before in-buf storage. Extracted new-scheduled position out of sender buffer. Cut off comments and reworked developer documentation. OFMT: separated proxy and sender classes for fmt result.

* Removed enter/leaveCS. Removed some comments and unused code. Simplifited stale()

* A small fix to prevent sending ACK for the sake of a former group member being closed

---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
#3358)

* [lib.logging] API renames in ofmt and hvu_compat. Improvements in ofmt

* Spellcheck. Fixed array layout in TestEnforcedEnc

* Improved handling of iomanip in ofmt. Merger CI changes from master

* Cleared out warnings for non-logging and clang

* Added platform report. Changed sigaction to POSIX only. Socketoptions freed from socket type

* Fixed template declaration

* Turned LOCALIF_WIN32 off by default. Synchronized configure options

---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* [core] Refaxed FormatTime with divmod

---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
…ols'. (#3365)

* [apps.support] Extracted out options module. Renamed 'testing' to 'tools'.

* Fixed invalid definitions for payload size in IPv6

* Imported script-deployed CI system

* Fixed monotonic clock condition. Fixed finding GTest

---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* [dev] Added BSTOW tool: generate live-planning transmission

* Excluded Tcl files from spellcheck

* Added and updated documentation
---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* [core] Reimplemented node type for HeapSet item types

---------

Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants