fix(hsts): only award preload bonus when includeSubDomains is set and max-age meets the 2-year minimum#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #81 (gate the preload bonus on
includeSubDomainsbeing present) and #87 (gate it onmax-age >= 63072000, the hstspreload.org 2-year minimum) — hstspreload.org actually requires both conditions, so applying either fix alone would leave the other gap open. The two PRs' diffs both rewrote the same single line, so they couldn't be merged sequentially without a manual reconciliation.Verified:
npm run typecheck,npm test(138/138, including both PRs' original test cases plus the combined case),npm run buildall pass. Also updated the pre-existingA+ at 90%grade-boundary fixture, which used amax-agebelow the new 2-year threshold and would otherwise have silently dropped to anA.Closes #81, closes #87.
Generated by Claude Code