Repository navigation
chore: merge upstream pingdotgg/t3code main - #18
Merged
Merged
Conversation
…ingdotgg#27756) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> Co-authored-by: maria-rcks <maria@kuuro.net>
Claude Opus 5.5 via Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily sync resolved a merge conflict with upstream. It lands by itself when CI passes.
Run: https://github.com/HYRMedia-LLC/t3code/actions/runs/41511835984
Agent summary
I resolved the one conflict and the registry tests pass. But I couldn't finish
vp run typecheck: the sandbox stops it before it reaches the server, web, desktop and mobile packages, so they haven't been typechecked.Decision:
apps/server/src/provider/ProviderInstanceRegistry.ts: kept the fork's launcher-awarecreate(...)call, which LiteLLM needs, and used upstream's new way of merging config secrets:secrets.config.length === 0 ? typedConfig : withSettingsSecrets(typedConfig, secrets.config). The old fork line spreadsecrets.configas an object, but upstream's feat(server): read source control host tokens from a secret provider pingdotgg/t3code#27756 made it an array, so that line would have been wrong. The fork's diff againstupstream/mainis now just the launcher lookup and its "cannot run through the launcher" fallback.Checks:
git diff --checkis clean. Nothing is staged, so git still lists the file asUU.secrets.config. The secret re-read path at line ~502 already uses the array type.hardened.patchdoesn't touch this file, so the resolution can't stop it applying. I couldn't rungit apply --checkbecause it needed approval.pnpm-lock.yamlwasn't conflicted, so I didn't runvp i.vp test runonProviderInstanceRegistry.test.tsandProviderInstanceRegistryHydration.test.tspassed, 2 files and 29 tests. TheEROFSerror printed after them is the GitHub summary writer hitting a read-only path, not a test failure. I ran them from the repo root because I couldn't change intoapps/server.vp run typecheckthree times. Each run failed inscriptsbecause it couldn't writescripts/tsconfig.tsbuildinfoon the read-only filesystem, which isn't a code error. That failure stops the run early. 16 of 20 packages passed, including contracts, provider-core, source-control-core and source-control-github. The sandbox also blocked running typecheck for one package andvp run --last-details.Before committing, someone should run
vp run typecheck(orvp run check:changed) andgit apply --check .github/hardened/hardened.patchon a writable checkout. I expect the server to typecheck, since upstream already passes the same config type intodriver.create, but that hasn't been confirmed.Files that differ from the automatic merge
apps/server/src/provider/ProviderInstanceRegistry.tsClaude Opus 5.5 via Claude Code.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.