Skip to content

Merge har.fyi under docs - #1332

Open
max-ostapenko wants to merge 15 commits into
mainfrom
merge-har-docs
Open

Merge har.fyi under docs#1332
max-ostapenko wants to merge 15 commits into
mainfrom
merge-har-docs

Conversation

@max-ostapenko

@max-ostapenko max-ostapenko commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR merges har.fyi content directly into httparchive.org under the /docs/ path:

  • Adds Astro Starlight integration (@astrojs/starlight, starlight-links-validator, starlight-llms-txt)
  • Migrates all guides, reference docs (tables, blobs, structs, custom metrics, functions), and assets into src/content/docs/
  • Integrates custom Starlight header matching HTTP Archive branding and search
  • Updates sitemap and timestamp generation to index doc pages
  • Updates site navigation and references pointing to har.fyi to relative /docs/ paths

@max-ostapenko max-ostapenko mentioned this pull request Sep 14, 2026
Merged
tunetheweb
tunetheweb requested changes Sep 20, 2026
View reviewed changes

@tunetheweb tunetheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking much better on desktop but still have the double hamburger menu issues on mobile:

Image

@max-ostapenko
max-ostapenko force-pushed the courageous-galliform branch 2 times, most recently from 62ed224 to 7e256f0 Compare September 20, 2026 14:16
Base automatically changed from courageous-galliform to main September 20, 2026 14:16
github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 20, 2026
View reviewed changes
Comment thread tools/generate/generate_timestamps.js Fixed
@max-ostapenko
feat: merge har.fyi under docs
572787d
@max-ostapenko
fix(linters): allow unsafe chars and non-unique ids for Starlight docs
9c9586f
@max-ostapenko
Merge branch 'merge-har-docs' of https://github.com/HTTPArchive/httpa…
9579c54 
…rchive.org into merge-har-docs

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko
chore: revert stricter rules in HTMLHint configuration
b016a8a 
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 0a70e01):

https://httparchive--pr1332-merge-har-docs-znie7fha.web.app

(expires Wed, 30 Sep 2026 21:55:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1069cba7974889c25bacf4f0a19ddb6735592729

@max-ostapenko
chore: update package-lock.json
39ee01d
@max-ostapenko
refactor: reuse main Header component in docs and add search slot
c2b143a 
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko
Merge branch 'main' into merge-har-docs
aef9cf1 
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko
feat: enforce light theme for documentation and update workbook links
0311adf 
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko
fix(ci): resolve HTMLHint attr-unsafe-chars, stylelint hue notation, …
59f1dc4 
…and CodeQL TOCTOU race condition
@max-ostapenko
fix(linters): adjust stylelint rules for custom property spacing and …
05130c1 
…color alias notation
@max-ostapenko
refactor: migrate hero image to src/assets and update docs and 404 re…
b3a4348 
…ferences
@tunetheweb

tunetheweb commented Sep 22, 2026

Copy link
Copy Markdown
Member

Looking better and better. It definitely feels like it's all part of one site now with the same menu persistent across all pages. It's not quite one case, but the illusion is there.

A few more asks for me:

  1. Could we have a consistent footer? Currently the Docs pages don't have any footer at all.
  2. I think, given it's a whole micro-site, this deserves it's own top-level menu item in the header rather than being buried under the About menu.
  3. I still don't understand the need for src/content/docs/docs. Can't it all be under src/content/docs/ and avoid that double doc/docs?

@max-ostapenko

max-ostapenko commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

@tunetheweb 'docs/docs/' is Starlights artifact.
It expects a collection under 'src/content/docs/', but as our website is not just docs, keeping the documentation right under 'docs/' will conflict with the rest of Astro pages.

And Starlight doesn't have a feature to define prefix.

@max-ostapenko
refactor: extract shared Footer component and add docs links to navig…
e63190a 
…ation

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko
Merge remote-tracking branch 'origin/main' into merge-har-docs
0a70e01 
# Conflicts:
#	package-lock.json
#	package.json
@max-ostapenko

max-ostapenko commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

@tunetheweb with unified footer and header now

tunetheweb
tunetheweb reviewed Sep 25, 2026
View reviewed changes

@tunetheweb tunetheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the docs Search work for you in the preview? Looks like we might need to add unsafe-eval to our CSP :-(

Comment thread src/components/Header.astro
align-items: center;
justify-content: space-between;
box-sizing: border-box;
max-width: 1200px;

@tunetheweb tunetheweb Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird when the docs page isn't constrained. The Logo in the header jumps to the right. Maybe we should drop this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunetheweb tunetheweb tunetheweb requested changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-ostapenko @tunetheweb @github-advanced-security