Conversation
|
🎉 Great job! Your PR title follows the correct format. 🚀 |
calmacx
added this pull request to stack #133
September 21, 2026 10:40
calmacx
marked this pull request as ready for review
September 21, 2026 10:41
calmacx
force-pushed
the
chore/GAT-9016-remove-express
branch
from
September 21, 2026 14:12
3e9fb3b to
c2eee13
Compare
calmacx
removed this pull request from stack #133
September 22, 2026 08:33
calmacx
added this pull request to stack #139
September 22, 2026 09:17
calmacx
force-pushed
the
chore/GAT-9016-remove-express
branch
from
September 22, 2026 09:24
c2eee13 to
6e17f8e
Compare
Deletes src/ (34 tracked files) and the orphaned root swagger.json, the legacy OpenAPI document superseded by the swagger-jsdoc spec now served at /openapi.json. Pure deletion — no behavioural change. src/ was kept deliberately through the dev cutover and the production promotion as the rollback artefact. With production soaked on the React Router build, it is dead weight that pollutes git grep, dependency audits and onboarding. Proven unreferenced before deleting. git grep for "src/" outside the tree itself returned four hits, all prose or config and none of them a code path: the eslint ignore entry (removed here), a comment in env.example citing src/app.js for the MAX_BODY_MB value (reworded), and two notes in the regression fixtures recording when the Express baseline retires (renumbered PR12 -> PR09). swagger.json had zero references anywhere. No workflow mentions src/ or jest, and jest is no longer a dependency. tests/data/*.json stay. Git reports them as R100/R096/R093 renames of src/utils/data/*, but they are live inputs to the Vitest suites and the originals were duplicates, not the same files. Verified on a production build: typecheck, lint and build all exit 0, and the suite is 62 passed across 10 files — identical to the run before the deletion, not merely green. Refs: upgrade-plans/ws1-pr09-remove-express.md
calmacx
force-pushed
the
chore/GAT-9016-remove-express
branch
from
September 22, 2026 09:28
6e17f8e to
858a394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes the legacy Express service —
src/(34 tracked files) and the orphaned rootswagger.json— plus theeslint.config.jsignore entry that existed only to keep the retained tree out of lint. No behavioural change.Why
src/was kept deliberately as the rollback artefact for the production cutover. Once production has soaked on the React Router build, the tree is dead weight: it pollutesgit grep, dependency audits and onboarding.swagger.jsonis the legacy OpenAPI document, superseded by the swagger-jsdoc spec served at/openapi.json.Testing
Verified on a production build, not dev mode:
npm run typecheck,npm run lintandnpm run buildall exit 0,build/openapi.jsonstill carries 10 paths, and the suite is 62 passed across 10 files — identical to the run before the deletion, which is the bar the plan set rather than merely "green".Proven unreferenced before deleting.
git grep "src/"outside the tree itself returned four hits, every one prose or config and none a code path: the eslint ignore (removed here), a comment inenv.examplecitingsrc/app.jsfor theMAX_BODY_MBvalue (reworded), and two notes in the regression fixtures recording when the Express baseline retires (renumbered PR12 → PR09).swagger.jsonhad zero references anywhere in the repo. No workflow mentionssrc/orjest, andjestis no longer a dependency.Notes
feat/GAT-9016-server-shell, the top of the migration stack, notdev.devstill runs Express today, so basing it there would show a deletion of the live service against a tree that has no replacement. Retarget todevonce the stack has landed.tests/data/*.jsonare kept. Git reports them as R100/R096/R093 renames ofsrc/utils/data/*, but they are live inputs to the Vitest suites — the originals were duplicates, not the same files.git checkout <this PR's parent sha> -- src, still trivial but no longer a one-command image swap on an existing tag.src/utils/swarmer.pyis a Python load-generation helper that was never part of the service and no one would notice vanishing until they needed it; and the regression pins (tests/regression/pins.json) are marked to retire whensrc/goes, but retiring them is a separate call about what CI compares against, not part of a pure deletion.🤖 Generated with Claude Code