fix(tgrep): map time-budget kill to a narrowing hint - #19
Conversation
execFile reports a budget timeout as killed:true with code null, which fell through to a generic failure. Killed (non-abort) runs now throw 'timed out after Nms; narrow with fileType/glob or raise tgrepTimeBudgetMs', covered by a regression test.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe tgrep execution path now reports child processes killed by the time budget as timeout failures. A test verifies the timeout error and elapsed budget. ChangesTimeout handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The timeout handling change is covered by a regression test and does not introduce an actionable merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review-bevinding bij #18: een time-budget-kill (killed:true, code null) viel door naar generieke foutmelding. Nu expliciete timeout-hint + regressietest. tgrep-tests 36/36 groen.