Skip to content

fix(tgrep): map time-budget kill to a narrowing hint - #19

Merged
OnlineChef (ChefGroep) merged 1 commit into
mainfrom
fix/tgrep-timeout-hint
Sep 12, 2026
Merged

OnlineChef (ChefGroep) merged 1 commit into
mainfrom
fix/tgrep-timeout-hint

Conversation

@ChefGroep

Copy link
Copy Markdown
Contributor

Review-bevinding bij #18: een time-budget-kill (killed:true, code null) viel door naar generieke foutmelding. Nu expliciete timeout-hint + regressietest. tgrep-tests 36/36 groen.

execFile reports a budget timeout as killed:true with code null,
which fell through to a generic failure. Killed (non-abort) runs
now throw 'timed out after Nms; narrow with fileType/glob or raise
tgrepTimeBudgetMs', covered by a regression test.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0e9fb5c8-b0a7-4bd0-906c-c8bb66ef15b7

📥 Commits

Reviewing files that changed from the base of the PR and between dd4eb72 and c64869f.

📒 Files selected for processing (2)
  • packages/pi-tools/src/tgrep.ts
  • packages/pi-tools/test/tgrep.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • GroepOnline/opencodex (manual)

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The tgrep execution path now reports child processes killed by the time budget as timeout failures. A test verifies the timeout error and elapsed budget.

Changes

Timeout handling

Layer / File(s) Summary
Timeout error and validation
packages/pi-tools/src/tgrep.ts, packages/pi-tools/test/tgrep.test.ts
defaultExec throws a budget-specific timeout error when the child process is killed. The test verifies the 100ms timeout message.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: misterwanted

Merge Risk: ⚪ Minimal · up to c6486

The timeout handling change is covered by a regression test and does not introduce an actionable merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the tgrep fix and the new handling for time-budget kills. It matches the main change.
Description check ✅ Passed The description explains the timeout error handling change, the regression test, and the test result. It is directly related to the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tgrep-timeout-hint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChefGroep
OnlineChef (ChefGroep) merged commit 090f427 into main Sep 12, 2026
24 of 25 checks passed
@ChefGroep
OnlineChef (ChefGroep) deleted the fix/tgrep-timeout-hint branch September 12, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant