Show a flow direction arrow on toggled pumps - #141
Open
qwaker00 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pump's facing is hard to read from its sprite alone — which is why vanilla pumps get a flow direction arrow in the first place.
Toggled pumps don't: they reach the world through hidden gauges using linked fluidbox connections and set
hide_connection_info, so the engine has no visible connection to draw one on.In my own playthrough I got into the habit of toggling a pump four times, all the way back around through a plain pump, just to catch a glimpse of its arrow.
Change:
scripts/valve_arrow.luarendersutility/fluid_indication_arrowon the three large togglable pumps, in alt mode, at the same size and position the engine uses on the plain pumps (centred on the outer edge of the output tile).migrations/nullius_2.0.12.luadraws the arrows in existing saves.Small pumps are left out; their graphics already read clearly, but one can easily (with some position adjustments) add arrows to it in future.
Vanilla also shows arrows on hover when alt mode is off. Implementation of that for toggled pumps is hacky, left out for simplicity.
Vanilla pumps to the left, toggle pumps to the right
