Repository navigation
fix(analytics): use Android ID and persist UUID fallbacks - #1624
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
+ Coverage 72.30% 72.33% +0.02%
==========================================
Files 102 102
Lines 15683 15683
==========================================
+ Hits 11340 11344 +4
+ Misses 3109 3106 -3
+ Partials 1234 1233 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android analytics currently uses
androidInfo.id(AndroidBuild.ID), so installations running the same OS build can report the same GA client ID and be counted as one user.Read Android's
Settings.Secure.ANDROID_IDthrough the android_id plugin instead. All native platforms attempt their device ID API on every startup, even when a persisted fallback exists. If the API fails or returns an empty ID, reuse the stored fallback or generate and persist a UUID v4. A successful lookup leaves any fallback unchanged for future failures. API-derived IDs are never copied into the fallback config field.Web uses the same backend config persistence for its UUID; browser localStorage is not used. Persist generated UUIDs in a dedicated
extra.deviceIdfield. Ignore the legacyanalyticsClientIdkey without migration, so historical build IDs cannot be reused as fallbacks. Existing Web/fallback identities start fresh when the new field is first populated. The analytics reporting protocol is unchanged.Dependencies:
Validation:
gradle :android_id:compileDebugKotlin --console=plain(AGP 8.11.1 / Kotlin 2.2.20 / JDK 17).git diff --checkpassed.