Remove Windows Server 2012 vestiges. - #2453
Open
rafaelwestphal wants to merge 1 commit into
Open
rafaelwestphal wants to merge 1 commit into
rafaelwestphal wants to merge 1 commit into
Conversation
Windows Server 2012 is EOL and no longer supported, so drop `Platform.Is2012()`. Windows Server 2016 still needs the Fluent Bit `Use_ANSI` workaround, so the `windows-2012` golden test platform becomes `windows-2016` (build 14393) to keep coverage of that quirk. Since OTel logging became the default (#2387), the `windows-logging-use_ansi` test runs its pipeline on OTel, so no golden had `Use_ANSI` anymore. Set `experimental_otel_logging: false` in that test so it covers the Fluent Bit workaround again, and regenerate its goldens. The other golden files are renamed without changes. b/438167232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Windows Server 2012 is EOL, so this removes
Platform.Is2012(). Windows Server 2016 still needs the Fluent BitUse_ANSIworkaround for winlog v2, so thewindows-2012golden test platform becomeswindows-2016(build 14393) to keep that coverage.Since #2387 made OTel logging the default,
windows-logging-use_ansiran on OTel and no golden containedUse_ANSIanymore. The test now setsexperimental_otel_logging: false, so itswindows-2016golden covers the workaround again (it differs fromwindowsonly byUse_ANSI True). The other goldens, which are most of the files in this PR, are moved fromwindows-2012/towindows-2016/without changes.Note: on 2012/2012 R2 hosts (unsupported), winlog v2 receivers that still run on Fluent Bit no longer get
Use_ANSI. The default OTel path is unaffected.Related issue
b/438167232
How has this been tested?
go test ./...(goldens regenerated only forwindows-logging-use_ansi).go build ./...,GOOS=windows go build ./...andGOOS=windows go vet -composites=false ./....Checklist: