chore: remove references to GitHub models - #290
Merged
Merged
Conversation
p-
requested review from
JarLob,
Kwstubbs,
anticomputer,
kevinbackhouse and
sylwia-budzynska
as code owners
August 13, 2026 08:35
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-retired GitHub Models (models.github.ai) provider and its related test coverage, aligning the agent’s endpoint/provider logic and documentation with GitHub Models’ retirement date in the PR description.
Changes:
- Removed the GitHub Models provider implementation and registry entry from
capi.py. - Deleted GitHub Models–specific tests (provider resolution and capability/tool-call detection).
- Updated test/docstrings to reflect GitHub Copilot as the default/known endpoint.
Show a summary per file
| File | Description |
|---|---|
| tests/test_sdk_anthropic_adapter.py | Removes GitHub Models assertion from bearer-auth behavior test and updates wording. |
| tests/test_capi_extended.py | Removes GitHub Models endpoint/provider tests for tool-call support and provider registry. |
| tests/test_api_endpoint_config.py | Updates default endpoint expectation and removes GitHub Models base-url assertion. |
| src/seclab_taskflow_agent/capi.py | Drops GitHub Models provider class/registry entry and updates module docstring accordingly. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
224
to
229
| def test_known_provider_uses_bearer_auth(): | ||
| """Known providers (CAPI, GitHub Models) should have bearer_auth=True.""" | ||
| """Known CAPI providers should have bearer_auth=True.""" | ||
| from seclab_taskflow_agent.capi import get_provider | ||
|
|
||
| provider = get_provider("https://api.githubcopilot.com") | ||
| assert provider.bearer_auth is True |
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
tests/test_sdk_anthropic_adapter.py:226
- The docstring refers to “CAPI” as a provider, but the provider here is actually GitHub Copilot (api.githubcopilot.com). Using the concrete provider name/endpoint in the docstring will avoid confusion for readers unfamiliar with the module acronym.
def test_known_provider_uses_bearer_auth():
"""Known providers like CAPI should have bearer_auth=True."""
from seclab_taskflow_agent.capi import get_provider
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
kevinbackhouse
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Models were retired on July 30, 2026
https://github.blog/changelog/2026-07-01-github-models-is-being-fully-retired-on-july-30-2026/