Skip to content

chore: remove references to GitHub models - #290

Merged
p- merged 2 commits into
mainfrom
p--rem-gh-models
Aug 17, 2026
Merged

chore: remove references to GitHub models#290
p- merged 2 commits into
mainfrom
p--rem-gh-models

Conversation

@p-

@p- p- commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Copilot AI lite review requested due to automatic review settings August 13, 2026 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-retired GitHub Models (models.github.ai) provider and its related test coverage, aligning the agent’s endpoint/provider logic and documentation with GitHub Models’ retirement date in the PR description.

Changes:

  • Removed the GitHub Models provider implementation and registry entry from capi.py.
  • Deleted GitHub Models–specific tests (provider resolution and capability/tool-call detection).
  • Updated test/docstrings to reflect GitHub Copilot as the default/known endpoint.
Show a summary per file
File Description
tests/test_sdk_anthropic_adapter.py Removes GitHub Models assertion from bearer-auth behavior test and updates wording.
tests/test_capi_extended.py Removes GitHub Models endpoint/provider tests for tool-call support and provider registry.
tests/test_api_endpoint_config.py Updates default endpoint expectation and removes GitHub Models base-url assertion.
src/seclab_taskflow_agent/capi.py Drops GitHub Models provider class/registry entry and updates module docstring accordingly.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment on lines 224 to 229
def test_known_provider_uses_bearer_auth():
"""Known providers (CAPI, GitHub Models) should have bearer_auth=True."""
"""Known CAPI providers should have bearer_auth=True."""
from seclab_taskflow_agent.capi import get_provider

provider = get_provider("https://api.githubcopilot.com")
assert provider.bearer_auth is True
Copilot AI review requested due to automatic review settings August 13, 2026 08:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

tests/test_sdk_anthropic_adapter.py:226

  • The docstring refers to “CAPI” as a provider, but the provider here is actually GitHub Copilot (api.githubcopilot.com). Using the concrete provider name/endpoint in the docstring will avoid confusion for readers unfamiliar with the module acronym.
def test_known_provider_uses_bearer_auth():
    """Known providers like CAPI should have bearer_auth=True."""
    from seclab_taskflow_agent.capi import get_provider
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@p-
p- merged commit 94cf78c into main Aug 17, 2026
10 checks passed
@p-
p- deleted the p--rem-gh-models branch August 17, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants