Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions .github/workflows/update-codeql-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,29 +136,11 @@ jobs:

- name: Bump release version (optional)
if: steps.release_bump.outputs.bump != ''
run: |
set -euo pipefail
# Invoke the pinned patch-release-me image directly via `docker run`
# instead of `uses: 42ByteLabs/patch-release-me@...`. That action's own
# action.yml builds its Docker CMD as a single YAML list item
# (`-m "${{ inputs.mode }}"`); Docker container actions don't go
# through a shell, so the literal quote characters end up baked into
# ONE argv token (`-m "minor"`). clap can't match that against
# "patch"/"minor"/"major" and silently falls back to its own default
# (Patch) - meaning `minor`/`major` have always quietly produced a
# patch bump instead (confirmed via a local repro: see PR history).
# Running the same pinned image ourselves via a normal shell `run:`
# step naturally splits `-m` and the mode value into separate argv
# entries, avoiding the bug entirely.
#
# Pinned by digest (not just tag) so the exact image content can't
# change out from under us - digest corresponds to the 0.6.5 tag.
docker run --rm \
--user "$(id -u):$(id -g)" \
-v "${{ github.workspace }}:/repo" \
-w /repo \
ghcr.io/42bytelabs/patch-release-me@sha256:d9d7abe7051855d0c395fec99d931acc002fb6b299ca16b8123e2c8ef0c7e750 \
--disable-banner bump -m ${{ steps.release_bump.outputs.bump }}
# TODO: Return to the upstream action after its runtime image is digest-pinned:
# https://github.com/42ByteLabs/patch-release-me/issues/169
uses: docker://ghcr.io/42bytelabs/patch-release-me:0.6.7@sha256:b9624359ce08707dfb4d22bcbf9d1a75f7f4718ccec610ddaa62280ffea98958
with:
args: --disable-banner bump -m ${{ steps.release_bump.outputs.bump }}
Comment thread
felickz marked this conversation as resolved.

- name: Set release prerelease flag (optional)
if: steps.release_bump.outputs.bump != ''
Expand Down
27 changes: 5 additions & 22 deletions .github/workflows/update-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,28 +36,11 @@ jobs:
private-key: ${{ secrets.SECLABS_APP_KEY }}

- name: "Patch Release Me"
run: |
set -euo pipefail
# Invoke the pinned patch-release-me image directly via `docker run`
# instead of `uses: 42ByteLabs/patch-release-me@...`. That action's own
# action.yml builds its Docker CMD as a single YAML list item
# (`-m "${{ inputs.mode }}"`); Docker container actions don't go
# through a shell, so the literal quote characters end up baked into
# ONE argv token (`-m "minor"`). clap can't match that against
# "patch"/"minor"/"major" and silently falls back to its own default
# (Patch) - meaning `minor`/`major` have always quietly produced a
# patch bump instead (confirmed via a local repro: see PR history).
# Running the same pinned image ourselves via a normal shell `run:`
# step naturally splits `-m` and the mode value into separate argv
# entries, avoiding the bug entirely.
# Pinned by digest (not just tag) so the exact image content can't
# change out from under us - digest corresponds to the 0.6.5 tag.
docker run --rm \
--user "$(id -u):$(id -g)" \
-v "${{ github.workspace }}:/repo" \
-w /repo \
ghcr.io/42bytelabs/patch-release-me@sha256:d9d7abe7051855d0c395fec99d931acc002fb6b299ca16b8123e2c8ef0c7e750 \
--disable-banner bump -m ${{ inputs.mode }}
# TODO: Return to the upstream action after its runtime image is digest-pinned:
# https://github.com/42ByteLabs/patch-release-me/issues/169
uses: docker://ghcr.io/42bytelabs/patch-release-me:0.6.7@sha256:b9624359ce08707dfb4d22bcbf9d1a75f7f4718ccec610ddaa62280ffea98958
with:
args: --disable-banner bump -m ${{ inputs.mode }}
Comment thread
felickz marked this conversation as resolved.

- name: Determine new release version
id: release_version
Expand Down