Fix is not an extension target of warning for extension packs - #191
Conversation
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
|
@copilot why is this causing python extension pack to fail ? |
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
This PR removes the empty lock file that was masking a separate Python compatibility issue. In that job, |
|
@copilot python pack create still failing.. is this cmd running fine local vs ci? |
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
…for codeql/python-all 7.2.x, drop malformed summaryModel row; clarify update-codeql-version.yml comment Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
The failure was schema validation errors (not the Fixed in the latest commit by merging |
|
@copilot what happened to the lock file deletion? All the changes brought them back - intentional or unintentional? Are they needed? Should they be removed again?
|
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Unintentional. The "placeholder" commit I pushed while starting the schema migration accidentally re-staged all 6 lock files that the earlier |
codeql pack create/publishon every<language>/extand<language>/ext-library-sourcespack emitted a warning per data extension:Root cause
These are CodeQL model/extension packs (
extensionTargets, deliberately nodependencies). Runningcodeql pack install/upgradeagainst them still (re)writes theircodeql-pack.lock.ymlwith an emptydependencies: {}map. A checked-in lock file in that state trips a known CodeQL CLI bug (github/codeql#20211): a laterpack create/publishthen can't resolve theaddsTo.packtarget and falsely warns, for every data extension file, even thoughextensionTargetscorrectly declares it.Confirmed locally: with the checked-in lock file present,
codeql pack createproduced 8–2276 warnings per affected directory; deleting it drops that to 0.Changes
codeql-pack.lock.ymlfiles undercsharp/ext,csharp/ext-library-sources,java/ext,java/ext-library-sources,python/ext,go/ext.codeql pack installstep beforecreate/publishforext/ext-library-sourcesinci.yml,publish.yml, andpr-suites-packs.sh(these packs have nothing to install anyway).update-codeql-version.yml'scodeql pack upgradesweep now skips*/extand*/ext-library-sourcesdirectories, so the lock file can't reappear on the next CLI bump.CONTRIBUTING.mdexplaining why these two pack types are neverinstalled/upgraded, alongside the existingql/hotspotsexclusion note.