Skip to content

Add support for redirects on 410 responses#155

Merged
ErvinsA merged 5 commits into
Geta:masterfrom
wezz:feature/support-410
Oct 7, 2025
Merged

Add support for redirects on 410 responses#155
ErvinsA merged 5 commits into
Geta:masterfrom
wezz:feature/support-410

Conversation

@wezz

@wezz wezz commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

In Optimizely, expired pages respond with a 410 http response which is ignored by the NotFound Handler.

This PR adds a option to enable the redirect manager to work on 410 responses.

@wezz

wezz commented Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

@jevgenijsp @kaspars-ozols @marisks
Could any of you have a look at this PR?

Comment thread src/Geta.NotFoundHandler/Core/RequestHandler.cs Outdated
@wezz wezz force-pushed the feature/support-410 branch from 7c225f8 to 64ce4c1 Compare September 29, 2025 14:10
@wezz wezz requested a review from ErvinsA September 29, 2025 14:13
@wezz

wezz commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

@ErvinsA I've made adjustments to this PR in regards to your feedback.
Can you you please have a look again?

ErvinsA
ErvinsA previously approved these changes Sep 30, 2025
@wezz

wezz commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

Pipeline was broken due to .net 6 no longer being supported. I updated the csproj files to use .net 8 instead

@wezz

wezz commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

@ErvinsA Looks like the "build" works after updating to .net 8 but there seems to be a issue with SonarCube

ErvinsA
ErvinsA previously approved these changes Oct 1, 2025
Comment thread src/Geta.NotFoundHandler/Core/RequestHandler.cs Outdated
@ErvinsA

ErvinsA commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

I think this is good to go to release!

@wezz

wezz commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

@ErvinsA Looks like there is still a issue in the pipeline related to SonarQube,
"The format of the analysis property sonar.login= is invalid" according to Githubs assistant.
image

@ErvinsA

ErvinsA commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

There is problems with SonarQube and pullrequests so that can be ignored.

@wezz

wezz commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

@ErvinsA Great!
Unfortunately I don't have write access so I can't complete and merge this PR myself

@ErvinsA ErvinsA merged commit b65535a into Geta:master Oct 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants