feat(react-sdk): migrate call recording list to new token design system - #2435
Conversation
- add speaking indicator in the preview
- fix fixed width
- fix fixed width
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe call recording list styling now uses design tokens for its header, title, rows, download action, and empty state. Row sizing is flexible, and the download button has distinct hover and active states. ChangesCall recording list styling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This styling-only update modernizes the call recording list without changing its API or behavior; no merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle sizeBuilt package output. Sizes in KB; delta vs
|
💡 Overview
Migrates
CallRecordingListonto the design tokens and aligns it withVideo Calling / Settings Modal / Recordings.The list was drawn for a single dark theme: a grey rule under every row, a
remfont size that tracked the consumer's root font size, and a white empty-state icon that was invisible in light mode. Per the spec the table header is now a filled pill, rows have no separator, and the download action is a 24×24 button with a 16px glyph instead of a bare 32px one.📝 Implementation notes
120pxcolumns replace200 / 100 / 100. They shrink below that basis where the spec saysshrink-0— applied literally a row needs432pxand clips the download button inreact-dogfood, which caps this list at400px.24pxbasis so the header and rows shrink identically; without it the columns drifted8px/16pxapart under440px.background-utility-hoveroverlay on the button, not a brand-blue glyph — the spec makes it aCore / Web / Button.48px: the button sets the content height, not the text.CallRecodingListdirectory, the two dead rules holding the last legacy variables (__toggle-button--active,__refresh-button), and the empty state's second copy line, which needs i18n.🎫 Ticket: https://linear.app/stream/issue/REACT-1146/migrate-callrecordinglist-to-design-tokens
📑 Docs: https://github.com/GetStream/docs-content/pull/
Summary by CodeRabbit