chore: derive release bump only from the title bang marker#66
Merged
Conversation
The release workflow scanned the PR title and body for the substring "BREAKING CHANGE" and forced a major bump on any match. Prose that merely mentioned the phrase, including a sentence stating there was no breaking change, tripped it: PR #65 was intended as a minor (7.2.0) but cut 8.0.0. Treat the `!` marker in the conventional-commits title (e.g. `feat!:`) as the sole breaking-change signal and stop reading the PR body entirely. Drop the now-unused --body / --body-file options and the body plumbing in release.yml.
mogita
changed the title
The Release Process section claimed a "BREAKING CHANGE" mention in the PR body/title forces a major bump. The workflow now derives the bump from the title's `!` marker only and ignores the body. Update the rules accordingly.
mogita
force-pushed
the
fix/release-bump-only-bang
branch
from
84fc69d to
2a0e361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow's
determine_bump_typeforced a major bump whenever the substringBREAKING CHANGEappeared anywhere in the PR title or body (/BREAKING[ -]CHANGE/iover free text). Any PR that merely mentions the phrase trips it. PR #65 was meant to be a minor (7.2.0) but cut 8.0.0 because its body contained the sentence "noBREAKING CHANGEmarker".Fix
Trust only the conventional-commits
!marker in the title (e.g.feat!:) as the breaking-change signal. Stop reading the PR body entirely, and remove the now-dead--body/--body-fileoptions plus the body plumbing inrelease.yml.Bump rules after this change (title-only):
feat!:/fix!:/type(scope)!:-> majorfeat:-> minorfix:/bug:-> patchDocs
!marker only.Verification
Drove the real CLI across cases (argv array, no shell mangling):
feat: ...-> minor,feat!: ...-> major,feat(mod)!: ...-> major,fix!: ...-> major,fix: ...-> patch,chore: ...-> nonefeat: mentions BREAKING CHANGE-> minor (the regression),BREAKING CHANGE: prose title-> nonerubocop: no offenses.