fix(ModelMappings): Added removed_components mapping to follow previo…

[MelchiorSchuh]

…us changes

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 12 concern(s)

• bindings/python/src/mesh/builder/graph_builder.cpp:30:10: warning: [misc-use-internal-linkage]

  function 'define_graph_builder' can be made static or moved into an anonymous namespace to enforce internal linkage

     30 |     void define_graph_builder( pybind11::module& module )
        |          ^
        |     static 

• include/geode/mesh/builder/graph_builder.hpp:44:30: warning: [cppcoreguidelines-special-member-functions]

  class 'GraphBuilder' defines a move constructor but does not define a destructor, a copy constructor, a copy assignment operator or a move assignment operator

     44 |     class opengeode_mesh_api GraphBuilder : public VertexSetBuilder
        |                              ^

• include/geode/mesh/builder/graph_builder.hpp:75:39: warning: [readability-identifier-length]

  parameter name 'nb' is too short, expected at least 3 characters

     75 |         index_t create_edges( index_t nb );
        |                                       ^

• include/geode/mesh/builder/graph_builder.hpp:167:47: warning: [readability-identifier-length]

  parameter name 'nb' is too short, expected at least 3 characters

    167 |         virtual void do_create_edges( index_t nb ) = 0;
        |                                               ^

• include/geode/model/representation/core/mapping.hpp:46:11: warning: [cppcoreguidelines-special-member-functions]

  class 'ModelMapping' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor

     46 |     class ModelMapping
        |           ^

• include/geode/model/representation/core/mapping.hpp:99:55: warning: [readability-identifier-naming]

  invalid case style for private member 'mappings'

     59 |             mappings.erase( type );
        |             ~~~~~~~~
        |             mappings_
     60 |         }
     61 | 
     62 |         [[nodiscard]] MappingType& operator[]( const ComponentType& type )
     63 |         {
     64 |             return mappings[type];
        |                    ~~~~~~~~
        |                    mappings_
     65 |         }
     66 | 
     67 |         [[nodiscard]] const absl::flat_hash_map< ComponentType, Mapping >&
     68 |             components_mappings() const
     69 |         {
     70 |             return mappings;
        |                    ~~~~~~~~
        |                    mappings_
     71 |         }
     72 | 
     73 |     private:
     74 |         absl::flat_hash_map< ComponentType, Mapping > mappings;
        |                                                       ^~~~~~~~
        |                                                       mappings_

• src/geode/mesh/builder/graph_builder.cpp:46:41: warning: [readability-identifier-length]

  variable name 'id' is too short, expected at least 3 characters

     46 |                 const geode::EdgeVertex id{ e, v };
        |                                         ^

• src/geode/mesh/builder/graph_builder.cpp:143:49: warning: [readability-identifier-length]

  parameter name 'nb' is too short, expected at least 3 characters

    143 |     index_t GraphBuilder::create_edges( index_t nb )
        |                                                 ^

• src/geode/mesh/builder/graph_builder.cpp:240:24: warning: [readability-function-cognitive-complexity]

  function 'copy' has cognitive complexity of 11 (threshold 10)

    240 |     void GraphBuilder::copy( const Graph& graph )
        |                        ^
  /__w/OpenGeode/OpenGeode/src/geode/mesh/builder/graph_builder.cpp:250:9: note: +1, including nesting penalty of 0, nesting level increased to 1
    250 |         if( graph_.impl_name() == graph.impl_name() )
        |         ^
  /__w/OpenGeode/OpenGeode/src/geode/mesh/builder/graph_builder.cpp:254:9: note: +1, nesting level increased to 1
    254 |         else
        |         ^
  /__w/OpenGeode/OpenGeode/src/geode/mesh/builder/graph_builder.cpp:256:13: note: +2, including nesting penalty of 1, nesting level increased to 2
    256 |             for( const auto e : Range{ graph.nb_edges() } )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/mesh/builder/graph_builder.cpp:258:17: note: +3, including nesting penalty of 2, nesting level increased to 3
    258 |                 for( const auto v : LRange{ 2 } )
        |                 ^
  /__w/OpenGeode/OpenGeode/src/geode/mesh/builder/graph_builder.cpp:262:21: note: +4, including nesting penalty of 3, nesting level increased to 4
    262 |                     if( vertex != NO_ID )
        |                     ^

• src/geode/mesh/builder/graph_builder.cpp:260:38: warning: [readability-identifier-length]

  variable name 'id' is too short, expected at least 3 characters

    260 |                     const EdgeVertex id{ e, v };
        |                                      ^

• src/geode/model/mixin/core/detail/relationships_impl.cpp:40:1: warning: [modernize-concat-nested-namespaces]

  nested namespaces can be concatenated

     40 | namespace geode
        | ^~~~~~~~~~~~~~~
     41 | {
        | ~
     42 |     namespace detail
        |     ~~~~~~~~~~~~~~~~
        |     namespace geode::detail

• src/geode/model/mixin/core/detail/relationships_impl.cpp:120:57: warning: [readability-identifier-length]

  parameter name 'to' is too short, expected at least 3 characters

    120 |             const ComponentID& from, const ComponentID& to )
        |                                                         ^

Have any feedback or feature suggestions? Share it here.