fix(e2e): match the renamed reload log line and guard every wait_log needle - #26
Merged
Merged
Conversation
…needle The SIGHUP add leg of run-full.sh waited for "config reload added this bucket", but the node now logs "config reload added this channel; starting its monitor", so the first GitHub e2e-full run timed out there against a working node. test_run_full_needles.py binds every wait_log needle in run-full.sh to a string literal of a tracing event (or, for a JSON-field needle, a declared field) in crates/*/src, so a reworded message fails script-tests instead of e2e-full.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIGHUP add leg of run-full.sh waited for "config reload added this bucket", but the node now logs "config reload added this channel; starting its monitor", so the first GitHub e2e-full run timed out there against a working node.
test_run_full_needles.py binds every wait_log needle in run-full.sh to a string literal of a tracing event (or, for a JSON-field needle, a declared field) in crates/*/src, so a reworded message fails script-tests instead of e2e-full.