fix(auth): enforce Vault token audience - #16
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04f1db9fa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
| } | ||
| setAuthContext(c, token, claims) | ||
| if !RequestTokenHasAudience(c, config.SentinelClientID) { |
There was a problem hiding this comment.
When Sentinel returns a valid multi-valued aud claim such as ["another-service", config.SentinelClientID], this rejects the token because setAuthContext stores only audiences[0] and RequestTokenHasAudience compares only that value. JWT audience arrays are unordered sets of intended recipients, so the middleware should test every value returned by claimStringSlice rather than requiring Vault to be first.
Useful? React with 👍 / 👎.
1 participant
sentinel:alloverrides from account and application access