ci: wire p987 into the build, release, and deploy automation - #227
Conversation
The aggregate build check waited on six services, so a p987 image failure would not have blocked a merge. Also add p987 to the release tag-bump allowlist in deploy.yml. That awk matches an explicit list of images rather than mapache/* as a whole, so without this its pinned tag in the infra kustomization would sit at whatever it was first set to while every other service moved forward.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff46380852
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # kerbecs and all comments/formatting untouched for a clean diff. | ||
| awk -v new="$NEW" ' | ||
| $0 ~ "- name: ghcr.io/gaucho-racing/mapache/(auth|vehicle|gr26|live|query|dashboard)$" { inmap=1; print; next } | ||
| $0 ~ "- name: ghcr.io/gaucho-racing/mapache/(auth|vehicle|gr26|p987|live|query|dashboard)$" { inmap=1; print; next } |
There was a problem hiding this comment.
When the next mapache release runs, this newly advances the p987 deployment to the release image, but scripts/release.sh still excludes p987 from GO_CONFIG_SERVICES; consequently p987/config/config.go remains at 0.1.0, so the deployed service's banner and /p987/ping response report the wrong version. Add p987 to the release script's Go service list so the image tag and runtime version stay synchronized.
Useful? React with 👍 / 👎.
| # kerbecs and all comments/formatting untouched for a clean diff. | ||
| awk -v new="$NEW" ' | ||
| $0 ~ "- name: ghcr.io/gaucho-racing/mapache/(auth|vehicle|gr26|live|query|dashboard)$" { inmap=1; print; next } | ||
| $0 ~ "- name: ghcr.io/gaucho-racing/mapache/(auth|vehicle|gr26|p987|live|query|dashboard)$" { inmap=1; print; next } |
There was a problem hiding this comment.
For every release that changes the p987 pin, the generated infrastructure PR body remains incomplete because the changelog loop reads the unchanged SERVICES value on line 23, which omits p987. Reviewers will therefore be told that only six images are being advanced even though this allowlist now modifies seven; add p987 to SERVICES as well.
Useful? React with 👍 / 👎.
Bumps its Version constant on a services release and its mapache-go dependency on a library release, alongside the other Go services.
The sed rewrote the Version line with a hardcoded five-space gap, which gofmt wants collapsed to one — so every services release left all four Go service configs unformatted. Fix the replacement and reformat the files it had already touched.
BK1031
changed the title
1 participant
p987 merged but wasn't hooked into any of the release machinery, so it would have been skipped by every automated step.
build.yml— addp987to the aggregate build check, which waited on six services and would not have caught a p987 image failuredeploy.yml— addp987to the release tag-bump allowlist. That awk matches an explicit image list rather thanmapache/*, so without this its pin in the infra kustomization would never move while every other service advancedscripts/release.sh— addp987toGO_CONFIG_SERVICESso a services release bumps itsVersionconstant and tags its image, and toGO_DEPENDENTSso a mapache-go release bumps its dependency tooLast commit is separable cleanup: the release sed rewrote the
Versionline with a hardcoded five-space gap that gofmt collapses to one, so every release left all four Go service configs unformatted. Fixed the replacement and reformatted the already-affected files. Drop that commit if you'd rather keep the diff to p987 alone.Verified the sed against p987's config (its field alignment differs from the others) — it matches and bumps correctly, and all five services still build.
Pairs with Gaucho-Racing/infrastructure#166, which pins p987 at
:latestuntil the next release gives it a real version.