Repository navigation
feat(repo): add ID-only filtered listings - #296
Draft
nicolasburtey wants to merge 1 commit into
Draft
nicolasburtey wants to merge 1 commit into
nicolasburtey wants to merge 1 commit into
Conversation
Add an opt-in list_ids_for_filters repo capability for batch workers that need matching IDs without hydrating complete event histories. Reuse existing filters, scopes, cursors, and lookahead while projecting IDs directly, and cover both directions and scoped views.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in
list_ids_for_filtersrepo option that generateslist_ids_for_filters_by_idand_in_opvariants for batch workers.first + 1lookahead.PaginatedQueryRet<EntityId, EntityByIdCursor>without joining the events table or hydrating entities.Downstream validation
Validated against Lana PR #10131 by switching the deposit-interest sweep to
list_ids_for_filters_by_id_in_op. The generated Lana queries selectDepositAccountIdwithout joiningcore_deposit_account_events.cargo check -p core-depositagainst this branch.cargo nextest run -p core-deposit interest_listing_filters_eligibility_before_pagination— passed.Verification
cargo test -p es-entity-macros --lib— 268 passed.cargo test --test virtual_filter_value --test virtual_filter_value_scoped— 7 passed.cargo test --workspace --no-run— passed.cargo clippy -p es-entity-macros --lib -- -D warnings— passed.cargo nextest run— 409 passed; one unrelated pre-existingtrybuilddiagnostic-text mismatch inid_source_is_sealed.rs.cargo fmt --all --checkandgit diff --check— passed.Workspace Clippy also reports two unrelated existing
useless_conversionwarnings insrc/query.rs.