Fix: Keep inbound transaction payloads as JSON objects - #834
Merged
Merged
Conversation
Fabric constructed a DTO class from parameter metadata before parseValidDTO ran. Pass the parsed JSON through and mark Fabric parameters as type object so the Submit/Evaluate input class is the one that is instantiated. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the chain-test copy in sync so inbound DTOs stay plain objects after Fabric schema type is forced to object.
Fabric keys transaction metadata by method name, so the same name on two contracts can bind the wrong DTO. parseValidDTO does the real parse.
Jehosephat
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fabric constructed a DTO class from parameter metadata before parseValidDTO ran. Pass the parsed JSON through and mark Fabric parameters as type object so the Submit/Evaluate input class is the one that is instantiated.