Native menu bar (slice 1: wiring, file associations, PR check) - #15
Closed
cjthompson wants to merge 5 commits into
Closed
cjthompson wants to merge 5 commits into
cjthompson wants to merge 5 commits into
Conversation
…viewer Adds bundle.fileAssociations for .md / .markdown / .mdx with role Viewer and text/markdown MIME so macOS offers Marky as Open With and Linux .desktop files carry the right MimeType. Co-Authored-By: Claude Code <noreply@anthropic.com>
Adds .github/workflows/check.yml running cargo test on ubuntu-22.04 and macos-latest so Linux-only compile failures show up at PR time instead of at v* tag push. Co-Authored-By: Claude Code <noreply@anthropic.com>
Implements the static menu structure (File / Edit / View / Window / Help), platform-gated app menu, accelerators, and the menu://action listener that replaces the global keydown effect. Adds menu.rs and folders.ts with placeholders (TODO(#00N)) so dependent tasks can fill them in. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
cjthompson
pushed a commit
to cjthompson/marky
that referenced
this pull request
Sep 30, 2026
…RVYDEV#15) - SourceView renders the full source as a CodeMirror editor. Edit mode makes it editable; Read mode keeps it view-only. Cmd+F CodeMirror search is wired through searchKeymap in lib/codemirror.ts. - extractHeadings returns the 1-based source line of each heading, so the TOC can scroll Source view alongside rendered view. - Toolbar view toggle and View Source View (CmdOrCtrl+/) added; the menu item lives next to Edit Mode in the View submenu.
cjthompson
pushed a commit
to cjthompson/marky
that referenced
this pull request
Sep 30, 2026
GRVYDEV#15) Combines: - GRVYDEV#14 inline block editing via CodeMirror 6 - GRVYDEV#15 full-document Source view and line-tagged headings
cjthompson
added a commit
to cjthompson/marky
that referenced
this pull request
Sep 30, 2026
Squash of feat/native-menu-bar-impl — steps 2-6 of docs/plans/native-menu-bar.md: - Rescan Folder (⇧⌘R) and Close Folder (⇧⌘W) for the active file's folder (folderForPath + rescan_folder command) - Open Recent ▸ and Open Recent Folder ▸ submenus (≤10 entries + Clear Menu; refresh_recent wired through read_file and add_folder) - Print… (⌘P) with print-only CSS for clean PDF export - Reveal in Finder / Show in File Manager (⌥⌘R) - Open With… (⌥⌘O, macOS only) — picker starts in /Applications - Export ▸ HTML… (⌥⌘E) and Export ▸ Markdown Copy… (⇧⌘S) Conflicts resolved against main@8fb9666 (edit-mode GRVYDEV#14/GRVYDEV#15): - src/App.tsx: combined folderForPath / exportHtml / sourceEdit imports - src/components/Viewer.tsx: combined 'relative' (block-editor) with 'print:h-auto print:overflow-visible' on the scroller Verified: cargo test 57/57; pnpm test 85 pass / 1 skip. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first three steps of the native menu bar plan (docs/plans/native-menu-bar.md):
src-tauri/src/menu.rsbuilds every menu (File / Edit / View / Window / Help) with platform gating;menu://actionevents route to the frontend viaonMenuAction; the globalkeydowneffect inApp.tsxis removed.bundle.fileAssociationsdeclares.md/.markdown/.mdxas Viewer, withtext/markdownand the daringfireball UTI so macOS offers Marky as Open With and Linux.desktopfiles carry the right MimeType..github/workflows/check.ymlrunscargo testonubuntu-22.04andmacos-latestso Linux-only compile failures surface at PR time instead of atv*tag push.Slice 1 lands 3 of 9 plan steps. Remaining: Rescan/Close Folder, Open Recent submenus, menu enabled state, Print/Reveal/Open With, Export HTML/Markdown, and Linux verification.
Verified on the integration branch (
feat/native-menu-bar-implat 31a8568):cargo test38/38 passing;pnpm test32 passing / 5 failing — same 5 pre-existing failures onmain(markdown.test.ts,theme.test.tsx), no regression.🤖 Generated with Claude Code