Bind HTTP request admission to transport EOF - #31
Merged
Merged
Conversation
Latch a newly observed transport cutoff into the request parser before servicing requests in the same recurrence. This keeps EOF from being mistaken for permission to admit another request while allowing an already-admitted request to finish. Do not rearm persistent request parsing after the request side has closed. Cover empty EOF and buffered pipeline suffix behavior with real socket half-closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requestantbefore request parsing in the same recurrenceWhy
The server services connections before receiving bytes, so receive can discover EOF after the connection phase has already checked the remoter. Without a same-recurrence handoff, the HTTP layer does not learn that inbound admission has ended. Response settlement can then create another persistent parser and make a buffered suffix eligible as a new request.
TCP EOF is directional. It must stop admission of new inbound requests while still allowing the server to finish the response for an already-admitted complete request. This change establishes that boundary without treating EOF as an immediate bidirectional abort.
Tracks ioflo#195. The eventual upstream port is blocked on ioflo#163 and the parser-settlement prerequisite chain.