Close the application-returned WSGI iterable - #27
Merged
Merged
Conversation
Retain the object returned by the WSGI application separately from its derived iterator so HIO can satisfy the PEP 3333 cleanup contract. Close that owner exactly once across normal completion and explicit termination without mistaking iterator cleanup for application resource release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PEP 3333 requires the server to call
close()on the iterable returned by the application. HIO previously discarded that object and retained onlyiter(iterable), which may be a distinct object with a different or absent cleanup contract.Tracks ioflo#192.
The behavior is generically upstreamable, but the code port is deferred until upstream PRs ioflo#179 and ioflo#181 plus the implementation of ioflo#191 land.