Settle HTTP responses before reconnecting after cutoff - #24
Merged
kentbull merged 1 commit intoAug 29, 2026
Merged
Conversation
Service the old Respondent while its EOF remains latched, package either its close-delimited success or framed failure, and only then clear residual receive bytes and reopen the connector. Preserve accepted SSE events and their retry interval, and defer work on the new connection until a later recurrence. Exercise all paths with real TCP clients, servers, sockets, and accepted Remoters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
EOF belongs to the transport generation that observed it. Reopening first resets the response parser before it can classify the old bytes, collapsing three different outcomes: a valid close-delimited response, a truncated framed response, and an SSE stream whose final accepted event changes reconnect timing. Settling the old parser before reconnect preserves message framing, failure truth, and application-visible SSE state.