Load mat files - #145
Open
Parvathy-jani wants to merge 2 commits into
Open
Load mat files#145Parvathy-jani wants to merge 2 commits into
Parvathy-jani wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug in el_paso/utils.py: .mat files saved in MATLAB's newer v7.3 format (secretly HDF5) couldn't be read by scipy, updated load_mat_data to try mat73 first (handles v7.3) and fall back to scipy.io.loadmat for older files.
Checklist
SPDX-FileContributor.ruff check ./ruff format .andty checkpass (or pre-commit ran clean).pytest -m basic(and/or-m visual) passes locally.README.md/CONTRIBUTING.mdupdated if this changes install steps, usage, or the processing-script list.pre-commitexecuted without any failuresNew processing recipe / satellite mission
Checklist
el_paso/recipes/<mission>/and follows the structure of an existing recipe (input handling, metadata, output to PRBEM-style standard names).el_paso/recipes/<mission>/__init__.pyupdated if a new module was added.README.md"Available processing scripts" list updated to include this recipe.ESA_CLIENT_ID), that's called out below.Notes for reviewers
Bug fix
Reproduction
Checklist
Notes for reviewers
Feature / enhancement
Design notes
Checklist
ruff.toml).examples/minimal_example.py(or another example) updated if this changes the primary usage pattern.README.mdupdated if this changes install steps, usage, or the feature set described there.Notes for reviewers
Documentation
Checklist
Notes for reviewers
Dependency bump / chore
Checklist
pyproject.tomlversion constraint updated consistently.IRBEM build still succeeds if the change touches build hooks or Fortran toolchain.
CI workflows (
.github/workflows/*.yml) still pass; any workflow file changes tested viaworkflow_dispatchor a draft PR run.Changelog/release notes updated if this affects the published package.
Notes for reviewers
Miscellaneous