Reset fluid state after convergence failure#4088
Open
dkachuma wants to merge 4 commits into
Open
Conversation
dkachuma
added
type: bug
dkachuma
requested review from
OmarDuran,
jhuang2601,
rrsettgast and
tjb-ltk
as code owners
tjb-ltk
reviewed
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Just to clarify the change. This resets K-values to those of last successful timestep?
Contributor
Author
There was a problem hiding this comment.
Resets to zero so they can be reinitialised using Wilson's correlation. Similar treatment to the well. The storage of the k-values is a heuristic attempt to improve convergence. If they are reinitialised, the flash might take a bit longer to converge but the solution should ultimately be the same.
tjb-ltk
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug breaking determinism in numerical Jacobian tests, where iterate-dependent constitutive state persisted across Newton attempts. While
CompositionalMultiphaseBase::resetStateToBeginningOfStepcorrectly restored primary variables (pressure, compositional density, and temperature), it failed to clearm_kValuesand other fluid properties.This PR updates
CompositionalMultiphaseBase::resetStateToBeginningOfStepto explicitly discard warm-started state held by the fluid model by callingfluid.initializeState(). This guarantees that rolled-back steps start clean and do not inherit iterate-dependent state from failed Newton attempts.